Skip to content

Add a log for the url #282098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TylerLeonhardt merged 1 commit into from
Dec 9, 2025
+3 −0
Merged

Add a log for the url #282098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions extensions/github-authentication/src/githubServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,9 +301,11 @@ export class GitHubServer implements IGitHubServer {
? 'faculty'
: 'none';
} else {
this._logger.info(`Unable to resolve optional EDU details. Status: ${result.status} ${result.statusText}`);
edu = 'unknown';
}
} catch (e) {
this._logger.info(`Unable to resolve optional EDU details. Error: ${e}`);
edu = 'unknown';
}

Expand Down
1 change: 1 addition & 0 deletions extensions/github-authentication/src/node/fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ async function fetchWithFallbacks(availableFetchers: readonly Fetcher[], url: st

async function tryFetch(fetcher: Fetcher, url: string, options: FetchOptions, logService: Log): Promise<{ ok: boolean; response: FetchResponse } | { ok: false; err: any }> {
try {
logService.debug(`FetcherService: trying fetcher ${fetcher.name} for ${url}`);
const response = await fetcher.fetch(url, options);
if (!response.ok) {
logService.info(`FetcherService: ${fetcher.name} failed with status: ${response.status} ${response.statusText}`);
Expand Down
Loading