Skip to content

Conversation

@osortega
Copy link
Contributor

@osortega osortega commented Dec 9, 2025

No description provided.

@osortega osortega self-assigned this Dec 9, 2025
@vs-code-engineering
Copy link

vs-code-engineering bot commented Dec 9, 2025

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsControl.ts
  • src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsView.ts

Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes no sense to me: we have a provider with events, that trigger refresh in the agent sessions. Why would we not be able to send an event through the provider API based on these conditions, why does this change have to go into the viewer? What if we decide to show the agent sessions somewhere else, would you duplicate the code there?

this._register(this.chatSessionsService.onDidChangeItemsProviders(({ chatSessionType: provider }) => this.resolve(provider)));
this._register(this.chatSessionsService.onDidChangeAvailability(() => this.resolve(undefined)));
this._register(this.chatSessionsService.onDidChangeSessionItems(provider => this.resolve(provider)));

cc @rebornix @joshspicer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants