Crash in small terminal window

[PtJade-Ceramic]

Brief description of your issue

https://aka.ms/AA13amrw

Steps to reproduce

shibayan/Sharprompt#283

Expected behavior

N/A

Actual behavior

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
 ---> System.ArgumentOutOfRangeException: The value must be greater than or equal to zero and less than the console's buffer size in that dimension. (Parameter 'top')
Actual value was 41.
   at System.ConsolePal.SetCursorPosition(Int32 left, Int32 top)
   at Sharprompt.Drivers.DefaultConsoleDriver.SetCursorPosition(Int32 left, Int32 top)
   at Sharprompt.Drivers.DefaultConsoleDriver.ClearLine(Int32 top)
   at Sharprompt.Internal.OffscreenBuffer.ClearConsole(Int32 cursorBottom, Int32 writtenLineCount)
   at Sharprompt.Internal.RenderScope.Dispose()
   at Sharprompt.Forms.FormRenderer.Render[TModel](Action`2 template, TModel result)
   at Sharprompt.Forms.FormRenderer.Render[TModel](Action`2 template, TModel result)
   at Sharprompt.Forms.FormBase`1.Start()
   at Sharprompt.Prompt.Input[T](InputOptions`1 options)
   at Sharprompt.Prompt.Input[T](Action`1 configure)
   at Sharprompt.Prompt.Input[T](String message, Object defaultValue, String placeholder, IList`1 validators)
   at Microsoft.WingetCreateCLI.PromptHelper.PromptValue[T](String message, Object model, String memberName, T instance)
   at InvokeStub_PromptHelper.PromptValue(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   --- End of inner exception stack trace ---
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)
   at Microsoft.WingetCreateCLI.PromptHelper.PromptPropertyAndSetValue[T](Object model, String memberName, T instance, Int32 minimum, Object validationModel, String validationName)
   at Microsoft.WingetCreateCLI.Commands.BaseCommand.PromptOptionalProperties[T](T manifest, List`1 optionalPropertiesNames)
   at Microsoft.WingetCreateCLI.Commands.NewLocaleCommand.GenerateLocaleManifest(Manifests originalManifests, LocaleManifest referenceLocaleManifest)
   at Microsoft.WingetCreateCLI.Commands.NewLocaleCommand.Execute()
   at Microsoft.WingetCreateCLI.Program.Main(String[] args)

Environment

wingetcreate.exe info
PS C:\Users\tbyta\GitHub\winget-pkgs\manifests\m\Microsoft\Sysinternals\Whois\1.21> wingetcreate.exe info                                                 
Windows 程序包管理器清单创建程序 v1.12.13.0
Copyright (c) Microsoft Corporation. All rights reserved.

操作系统: Microsoft Windows NT 10.0.26200.0
系统体系结构: Arm64

Winget-Create 目录  路径                                                                                                             
---------------------------------------------------------------------------------------------------------------------------------
日志                %LOCALAPPDATA%\Packages\Microsoft.WindowsPackageManagerManifestCreator_8wekyb3d8bbwe\LocalState\DiagOutputDir  
用户设置              %LOCALAPPDATA%\Packages\Microsoft.WindowsPackageManagerManifestCreator_8wekyb3d8bbwe\LocalState\settings.json  
安装程序缓存            %TEMP%\wingetcreate                                                                                            

链接                                                  
----------------------------------------------------
隐私声明   https://aka.ms/winget-create-privacy         
许可协议   https://aka.ms/winget-create-license         
第三方声明  https://aka.ms/winget-create-3rdPartyNotice  
主页     https://aka.ms/winget-create

[github-actions]

Possible duplicate(s):

Thank you for submitting this issue.

The issue(s) below may already track your request or bug. Please take a look — if one of them matches, give that issue a 👍 and close this one as a duplicate. Older or curated issues are preferred as the canonical one to follow.

• Exception has been thrown by the target of an invocation #306 — Same System.Reflection.TargetInvocationException crash originating from Sharprompt's console driver via PromptHelper.PromptValue, though the root cause there was an invalid console handle rather than a small buffer size.

Template: msftbot/duplicate/surfaced by Duplicate Surfacing

[PtJade-Ceramic]

Possible duplicate(s):

Thank you for submitting this issue.

The issue(s) below may already track your request or bug. Please take a look — if one of them matches, give that issue a 👍 and close this one as a duplicate. Older or curated issues are preferred as the canonical one to follow.

• Exception has been thrown by the target of an invocation #306 — Same System.Reflection.TargetInvocationException crash originating from Sharprompt's console driver via PromptHelper.PromptValue, though the root cause there was an invalid console handle rather than a small buffer size.

Template: msftbot/duplicate/surfaced by Duplicate Surfacing

Hi, thanks for triaging. A quick note on this one — I believe this is not the same issue as #306.

Root cause

This is the known small-console-buffer crash in Sharprompt (the interactive prompting library winget-create uses): DefaultConsoleDriver.SetCursorPosition / OffscreenBuffer.ClearConsole compute an absolute line number and call Console.SetCursorPosition without clamping to the current buffer bounds. When the console buffer is too small (e.g. a short terminal window), it throws ArgumentOutOfRangeException (Parameter 'top').

It's tracked upstream as shibayan/Sharprompt#283, and Sharprompt already fixed it via shibayan/Sharprompt#373.

Why winget-create still crashes

winget-create pins Sharprompt 2.4.5 in Directory.Packages.props, which predates the fix. I reproduced this on the latest winget-create 1.12.13.0 (arm64) — full stack trace is in the issue body. Bumping the Sharprompt package to a version that includes the fix should resolve this.

Not a duplicate of #306

The duplicate-surface bot suggested #306, but that has a different root cause (IOException: The handle is invalid on Console.CursorVisible — an invalid console handle) and is already fixed. This issue is specifically the buffer-size case.

Meanwhile, a workaround for affected users is to enlarge the terminal window / scroll buffer before running the wizard.