OSD should adapt to OSC top margins like console

[Samillion]

Current behavior

Using title-bar=no or border=no

When the window controls show, they overlap.

Expected behavior of the wanted feature

OSD should adapt with OSC's top margins to not cause an overlap, same as console's global_margins.t

Log File

No response

Sample Files

No response

[avih]

I agree it's a bug for the user.

But the way it's phrased, it sounds like mpv should respect whatever the osc is doing, and I'm not very fond of this direction of data flow.

I would prefer it to be "The OSC should ensure the OSD does not clash with window-title/topbar/whatever".

But as a bug description, it should be "The OSD clashes with the OSC whatever", and let the developers decide where the bug is, and where it's best to address it.

[Samillion]

Fair enough. Thank you.

[avih]

Fair enough. Thank you.

I said I agree it's a bug. I think it should be kept open.

I just said it can also be solved at osc.lua, which is still part of mpv.

[Keith94]

Would be nice to see this fixed too rather than relying on the osd-margin-y workaround.

[kasper93]

This also should apply to subtitles, that should be moved to visible area.

[avih]

This also should apply to subtitles, that should be moved to visible area.

I can't speak for others, but I wouldn't want that for myself.

I use the OSC box layout, and my subs are configured to be at the same Y-pos as the OSC, and that's exactly how I want it to stay, because otherwise it would obscure too much of the content if they don't overlap.

[kasper93]

This also should apply to subtitles, that should be moved to visible area.

I can't speak for others, but I wouldn't want that for myself.

I use the OSC box layout, and my subs are configured to be at the same Y-pos as the OSC, and that's exactly how I want it to stay, because otherwise it would obscure too much of the content if they don't overlap.

Obviously it would be an option and BOX layout itself would be excluded. Principle doesn't change, any OSD element should respect global margins.

[guidocella]

box layout doesn't set OSC margins, so it wouldn't be affected.

I also think it's more correct to fix it in the C code because it will work correctly if you change --osd-margin-y or resize the OSC while it is visible.

[kasper93]

box layout doesn't set OSC margins, so it wouldn't be affected.

It wouldn't make sense for BOX to set them, so we are good.

[avih]

The box example was just to give more details.

My point was that some people might want them to overlap, even with bottom layouts, because otherwise it increases the content area which is obscured.

But if you think it should be configurable, then sure, this would solve it.

[guidocella]

Do you also want this with visibility=auto? If so this either needs to be fixed in the OSC or it should also set margins with visibility=auto.