[Test coverage] #139 B2 — DocumentLinkProvider entry-point smoke for no-solution mode

[msarson]

Deferred B2 from #139 / MT kanban task ecddd1a7.

Background

#139 B1 shipped entry-point smoke coverage for Hover + Implementation in no-solution mode (Tests 1 + 3) along with the Gap A fix at MemberLocatorService.resolveFilePath. Test 4 (DocumentLinkProvider.provideDocumentLinks) was deferred because the DocumentLink path requires the FileRelationshipGraph (FRG) to be built — and FRG no-solution-mode build is tracked separately under d7e34cc5. Pick up when FRG cluster lands.

Test shape

DocumentLinkProvider.provideDocumentLinks on source MyProg.clw containing INCLUDE('MyClass.inc') with MyClass.inc in libsrc, in no-solution mode (SolutionManager.instance = null, serverSettings.libsrcPaths pointed at the fixture's libsrc dir).

Bidirectional-pin shape per feedback_bidirectional_pin_assertion:

• Positive: at least one DocumentLink returned; link target URI inside the libsrc dir; link target basename matches MyClass.inc.
• Negative regression sentinel: source with no INCLUDEs returns empty link list (provider doesn't fabricate links).

Substrate

Reuses NoSolutionFixture + cursorPositionOf already landed in #139 Gap A close-out.

FRG seeding is the new substrate requirement — DocumentLinkProvider.provideDocumentLinks bails immediately if frg.isBuilt is false (line 26). A seedFrgForFixture(spec) helper or equivalent is the substrate add. Flagged as "FRG seeding" in #139 substrate-gap hypothesis.

Estimate

~30-45min test + 1-2hr FRG seeding substrate. Honest 2-3hr.

Cross-references

• MT kanban: `ecddd1a7`
• Blocked by: `d7e34cc5` (FRG no-solution-mode build)
• Surfaced from: [Test coverage] Full LSP entry-point smoke coverage for no-solution mode #139 / 70350986 (B1 close-out 2026-05-14)
• [Test coverage] Full LSP entry-point smoke coverage for no-solution mode #139 open question 1 named this dependency explicitly.

Cross-references (related #139 work)

• Gap A fix (MemberLocatorService routing) — landed in [Test coverage] Full LSP entry-point smoke coverage for no-solution mode #139 commit `8421311`
• Gap B (DefinitionProvider F12 INCLUDE-aware guard) — separate task `651935b9` + GH issue paired

[msarson]

Implemented in commit e26079b4da1f6b7f3b5f6cf61704f34dc73d6199: no-solution entry-point smoke coverage for DocumentLinkProvider.provideDocumentLinks (positive INCLUDE-to-libsrc assertion + negative no-INCLUDE sentinel), with seeded FRG substrate and per-test FRG reset.