Skip to content

[tmp] feat: add calendar delegation feature#8336

Draft
hamza221 wants to merge 3 commits into
mainfrom
AI/vibe-fixes
Draft

[tmp] feat: add calendar delegation feature#8336
hamza221 wants to merge 3 commits into
mainfrom
AI/vibe-fixes

Conversation

@hamza221
Copy link
Copy Markdown
Contributor

@hamza221 hamza221 commented May 14, 2026

Edit: temporary pr for testing, almost fully vibe coded. Please ignore

GVodyanov and others added 3 commits May 6, 2026 17:03
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>

# Conflicts:
#	package-lock.json
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
@SebastianKrupinski
Copy link
Copy Markdown
Contributor

Hey,

I know this is still a draft, but before you get too far, a couple things:

a) pretty much all the code in the delegation service, should live in the Cdav-Library. Also phrasing xml strings with variable injection and parsing responses with regex strings is a no no. Please use build in function to do this. You can look at the Cdav library for refereance.

b) any newly created files should be in TypeScript with setup and Vue composition api. Cdav-library is exempt from this as it does not use typescript yet. Please see AppNavigationHeaderViewMenu.vue for reference. Sorry, but I've enforced this for other PR's so its only fair.

@hamza221
Copy link
Copy Markdown
Contributor Author

Hey,

I know this is still a draft, but before you get too far, a couple things:

a) pretty much all the code in the delegation service, should live in the Cdav-Library. Also phrasing xml strings with variable injection and parsing responses with regex strings is a no no. Please use build in function to do this. You can look at the Cdav library for refereance.

b) any newly created files should be in TypeScript with setup and Vue composition api. Cdav-library is exempt from this as it does not use typescript yet. Please see AppNavigationHeaderViewMenu.vue for reference. Sorry, but I've enforced this for other PR's so its only fair.

This is just a Tmp pr, for local debugging ( to fix the backend) i agree with the point but should be posted on the actual pr open by @GVodyanov

@hamza221 hamza221 added the wontfix This will not be worked on label May 14, 2026
@SebastianKrupinski
Copy link
Copy Markdown
Contributor

This is just a Tmp pr, for local debugging ( to fix the backend) i agree with the point but should be posted on the actual pr open by @GVodyanov

Ah! Okay, will do

@hamza221 hamza221 changed the title feat: add calendar delegation feature [tmp] feat: add calendar delegation feature May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants