Skip to content

Commit 2bc35e2

Browse files
committed
fixup! ffi: reject direct SharedArrayBuffer pointers
1 parent 669fac1 commit 2bc35e2

1 file changed

Lines changed: 11 additions & 7 deletions

File tree

test/ffi/test-ffi-fast-buffer.js

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,16 +80,20 @@ test('optimized pointer arguments reject direct SharedArrayBuffers', () => {
8080
const shared = new SharedArrayBuffer(1);
8181
const expected = { code: 'ERR_INVALID_ARG_VALUE' };
8282

83+
function callFirstByte(value) {
84+
return firstByte(value);
85+
}
86+
8387
try {
84-
assert.throws(() => firstByte(shared), expected);
88+
assert.throws(() => callFirstByte(shared), expected);
8589

86-
eval('%PrepareFunctionForOptimization(firstByte)');
87-
firstByte(regular);
88-
firstByte(regular);
89-
eval('%OptimizeFunctionOnNextCall(firstByte)');
90-
firstByte(regular);
90+
eval('%PrepareFunctionForOptimization(callFirstByte)');
91+
callFirstByte(regular);
92+
callFirstByte(regular);
93+
eval('%OptimizeFunctionOnNextCall(callFirstByte)');
94+
callFirstByte(regular);
9195

92-
assert.throws(() => firstByte(shared), expected);
96+
assert.throws(() => callFirstByte(shared), expected);
9397
} finally {
9498
lib.close();
9599
}

0 commit comments

Comments
 (0)