http: fixing tests

test-http-header-overflow.js:
the llhttp doesn't  count space and separator, so to generate a breaking
number of chars, just add +1 to the maxHeaderSize

test-http-max-http-headers.js:
remove the +1 that was referring to the slash of the uri, because
it's not being counted anymore

Author: caiolrm

test/parallel/test-http-header-overflow.js

@@ -1,18 +1,34 @@
+// Flags: --expose-internals
 'use strict';
+const { expectsError, mustCall } = require('../common');
 const assert = require('assert');
 const { createServer, maxHeaderSize } = require('http');
 const { createConnection } = require('net');
-const { expectsError, mustCall } = require('../common');
+
+const { getOptionValue } = require('internal/options');
+
+const currentParser = getOptionValue('--http-parser');
+
+const sumOfLengths = (strings) => strings
+  .map((string) => string.length)
+  .reduce((a, b) => a + b);
+
+const getBreakingLength = () => {
+  if (currentParser === 'llhttp') {
+    return maxHeaderSize - HEADER_NAME.length + 1;
+  } else {
+    return maxHeaderSize - HEADER_NAME.length - HEADER_SEPARATOR -
+      (2 * CRLF.length) + 1;
+  }
+};
 
 const CRLF = '\r\n';
-const DUMMY_HEADER_NAME = 'Cookie: ';
-const DUMMY_HEADER_VALUE = 'a'.repeat(
-  // Plus one is to make it 1 byte too big
-  maxHeaderSize - DUMMY_HEADER_NAME.length - (2 * CRLF.length) + 1
-);
+const HEADER_NAME = 'Cookie';
+const HEADER_SEPARATOR = ': ';
+const HEADER_VALUE = 'a'.repeat(getBreakingLength());
 const PAYLOAD_GET = 'GET /blah HTTP/1.1';
 const PAYLOAD = PAYLOAD_GET + CRLF +
-  DUMMY_HEADER_NAME + DUMMY_HEADER_VALUE + CRLF.repeat(2);
+  HEADER_NAME + HEADER_SEPARATOR + HEADER_VALUE + CRLF.repeat(2);
 
 const server = createServer();
 
@@ -21,7 +37,13 @@ server.on('connection', mustCall((socket) => {
     type: Error,
     message: 'Parse Error',
     code: 'HPE_HEADER_OVERFLOW',
-    bytesParsed: maxHeaderSize + PAYLOAD_GET.length,
+    bytesParsed: sumOfLengths([
+      PAYLOAD_GET,
+      CRLF,
+      HEADER_NAME,
+      HEADER_SEPARATOR,
+      HEADER_VALUE
+    ]) + 1,
     rawPacket: Buffer.from(PAYLOAD)
   }));
 }));

test/sequential/test-http-max-http-headers.js

@@ -123,7 +123,7 @@ const test2 = common.mustCall(() => {
     'X-CRASH: ';
 
   // /, Host, localhost, Agent, node, X-CRASH, a...
-  const currentSize = 1 + 4 + 9 + 5 + 4 + 7;
+  const currentSize = 4 + 9 + 5 + 4 + 7;
   headers = fillHeaders(headers, currentSize);
 
   const server = http.createServer(common.mustNotCall());