[IMP] estate: add constraints to verify amounts and unique names (ch 10)

Author: antonio-pimentel

estate/models/estate_property.py

@@ -1,5 +1,6 @@
 from odoo import api, fields, models
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
+from odoo.tools.float_utils import float_compare, float_is_zero
 
 
 class EstateProperty(models.Model):
@@ -44,6 +45,11 @@ class EstateProperty(models.Model):
     offer_ids = fields.One2many("estate.property.offer", "property_id", string="Offers")
     best_price = fields.Float(string="Best Offer", compute="_compute_best_offer")
 
+    _check_expected_price = models.Constraint(
+        "CHECK(expected_price > 0)", "Expected Price must be strictly positive.")
+    _check_selling_price_positive = models.Constraint(
+        "CHECK(selling_price >= 0)", "Selling Price must be positive.")
+
     @api.depends("living_area", "garden_area")
     def _compute_total_area(self):
         for record in self:
@@ -65,6 +71,14 @@ def _onchange_garden(self):
             self.garden_area = 0
             self.garden_orientation = None
 
+    @api.constrains('selling_price')
+    def _check_selling_price_90_percent(self):
+        for record in self:
+            if float_is_zero(record.selling_price, precision_digits=2):
+                continue
+            if float_compare(record.expected_price * 0.9, record.selling_price, precision_digits=2) > 0:
+                raise ValidationError("The selling price must be at least 90% of the expected price! You must reduce the expected price if you want to accept this offer.")
+
     def action_sold(self):
         for record in self:
             if record.state == "cancelled":

estate/models/estate_property_offer.py

@@ -17,6 +17,8 @@ class EstatePropertyOffer(models.Model):
         compute="_compute_date_deadline",
         inverse="_inverse_date_deadline")
 
+    _check_price = models.Constraint("CHECK(price > 0)", "Offer price must be strictly positive.")
+
     @api.depends("validity")
     def _compute_date_deadline(self):
         for record in self:
@@ -31,7 +33,7 @@ def _inverse_date_deadline(self):
 
     def action_accept_offer(self):
         for record in self:
-            if any([offer.status == 'accepted' for offer in record.property_id.offer_ids]):
+            if any(offer.status == 'accepted' for offer in record.property_id.offer_ids):
                 raise UserError("An offer for this property has already been accepted.")
             else:
                 record.status = 'accepted'

estate/models/estate_property_tag.py

@@ -6,3 +6,5 @@ class EstatePropertyTag(models.Model):
     _description = "Estate property tag"
 
     name = fields.Char('Tag', required=True)
+
+    _check_name = models.Constraint("UNIQUE(name)", "Tag name must be unique.")

estate/models/estate_property_type.py

@@ -6,3 +6,5 @@ class EstatePropertyType(models.Model):
     _description = "Estate property type"
 
     name = fields.Char('Type', required=True)
+
+    _check_name = models.Constraint("UNIQUE(name)", "Property type name must be unique.")