-
Notifications
You must be signed in to change notification settings - Fork 549
Outdated getting started docs #3763
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomershelp wantedGood for taking. Extra help will be provided by maintainersGood for taking. Extra help will be provided by maintainerstriage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Description
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomershelp wantedGood for taking. Extra help will be provided by maintainersGood for taking. Extra help will be provided by maintainerstriage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Hi, while going through the getting started docs I noticed that the example code listed there for how to register a custom global log handler is outdated and does not compile anymore. Specifically the
SetLogHandlersignature seems to have changed to usenostd::shared_ptrinstead of non-pointer value. Here's the offending line:opentelemetry::sdk::common::internal_log::GlobalLogHandler::SetLogHandler(CustomLogHandler());Tip: React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding
+1orme too, to help us triage it. Learn more here.