Skip to content

Commit cee7023

Browse files
fix: package release time is now obtained from any sdist released as well.
Signed-off-by: Abhinav Pradeep <[email protected]>
1 parent b9da4b0 commit cee7023

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/macaron/slsa_analyzer/package_registry/pypi_registry.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -664,7 +664,7 @@ class PyPIPackageJsonAsset:
664664
wheel_filename: str = field(init=False)
665665

666666
#: The datetime that the wheel was uploaded.
667-
wheel_upload_time: datetime = field(init=False)
667+
package_upload_time: datetime = field(init=False)
668668

669669
#: The pypi inspector information about this package
670670
inspector_asset: PyPIInspectorAsset
@@ -809,6 +809,8 @@ def get_wheel_url(self, tag: str = "none-any") -> str | None:
809809
if not urls:
810810
return None
811811
for distribution in urls:
812+
# In this way we have an package_upload_time even if we dont have cannot find the wheel
813+
self.package_upload_time = datetime.strptime(distribution.get("upload_time") or "", "%Y-%m-%dT%H:%M:%S")
812814
# Only examine wheels
813815
if distribution.get("packagetype") != "bdist_wheel":
814816
continue
@@ -819,7 +821,7 @@ def get_wheel_url(self, tag: str = "none-any") -> str | None:
819821
# Continue to getting url
820822
wheel_url: str = distribution.get("url") or ""
821823
if wheel_url:
822-
self.wheel_upload_time = datetime.strptime(distribution.get("upload_time") or "", "%Y-%m-%dT%H:%M:%S")
824+
self.package_upload_time = datetime.strptime(distribution.get("upload_time") or "", "%Y-%m-%dT%H:%M:%S")
823825
try:
824826
parsed_url = urllib.parse.urlparse(wheel_url)
825827
except ValueError:
@@ -1130,7 +1132,7 @@ def get_chronologically_suitable_setuptools_version(self) -> str:
11301132
str
11311133
Chronologically likeliest setuptools version
11321134
"""
1133-
return self.pypi_registry.get_matching_setuptools_version(self.wheel_upload_time)
1135+
return self.pypi_registry.get_matching_setuptools_version(self.package_upload_time)
11341136

11351137

11361138
def find_or_create_pypi_asset(

0 commit comments

Comments
 (0)