Skip to content

Commit 2bf2d1f

Browse files
committed
Merge branch 'jira-wktui-569' into 'develop-2.0'
Check attribute disabled status when related attributes are removed See merge request weblogic-cloud/weblogic-toolkit-ui!433
2 parents 4adf02f + e07ea0c commit 2bf2d1f

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

webui/src/js/utils/modelEdit/meta-handlers.js

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ define(['knockout', 'utils/wkt-logger', 'utils/modelEdit/model-edit-helper'],
123123
const methodOrder = attributeMap['MethodOrder'];
124124
return ko.computed(() => {
125125
const order = ModelEditHelper.getDerivedValue(methodOrder.observable());
126-
return order === undefined || order === 'OCSP';
126+
return isUndefined(order) || order === 'OCSP';
127127
});
128128
};
129129

@@ -135,7 +135,7 @@ define(['knockout', 'utils/wkt-logger', 'utils/modelEdit/model-edit-helper'],
135135
const methodOrder = attributeMap['MethodOrder'];
136136
return ko.computed(() => {
137137
const order = ModelEditHelper.getDerivedValue(methodOrder.observable());
138-
return order === undefined || order === 'CRL';
138+
return isUndefined(order) || order === 'CRL';
139139
});
140140
};
141141

@@ -328,7 +328,7 @@ define(['knockout', 'utils/wkt-logger', 'utils/modelEdit/model-edit-helper'],
328328
const migrationBasis = attributeMap['MigrationBasis'];
329329
return ko.computed(() => {
330330
const basis = ModelEditHelper.getDerivedValue(migrationBasis.observable());
331-
return basis !== undefined && basis !== 'database';
331+
return !isUndefined(basis) && basis !== 'database';
332332
});
333333
};
334334

@@ -344,7 +344,7 @@ define(['knockout', 'utils/wkt-logger', 'utils/modelEdit/model-edit-helper'],
344344
const clusterMessagingMode = attributeMap['ClusterMessagingMode'];
345345
return ko.computed(() => {
346346
const mode = ModelEditHelper.getDerivedValue(clusterMessagingMode.observable());
347-
return mode !== undefined && mode !== 'unicast';
347+
return !isUndefined(mode) && mode !== 'unicast';
348348
});
349349
};
350350

@@ -435,7 +435,7 @@ define(['knockout', 'utils/wkt-logger', 'utils/modelEdit/model-edit-helper'],
435435
const archiveType = attributeMap['DiagnosticDataArchiveType'];
436436
return ko.computed(() => {
437437
const type = ModelEditHelper.getDerivedValue(archiveType.observable());
438-
return type !== undefined && type !== 'FileStoreArchive';
438+
return !isUndefined(type) && type !== 'FileStoreArchive';
439439
});
440440
};
441441

@@ -475,7 +475,7 @@ define(['knockout', 'utils/wkt-logger', 'utils/modelEdit/model-edit-helper'],
475475
const persistenceStrategy = attributeMap['PersistenceStrategy'];
476476
return ko.computed(() => {
477477
const strategy = ModelEditHelper.getDerivedValue(persistenceStrategy.observable());
478-
return strategy !== undefined && strategy !== 'LOCAL_ACCESS_ONLY';
478+
return !isUndefined(strategy) && strategy !== 'LOCAL_ACCESS_ONLY';
479479
});
480480
};
481481

@@ -507,12 +507,16 @@ define(['knockout', 'utils/wkt-logger', 'utils/modelEdit/model-edit-helper'],
507507
const fieldObservable = attributeMap[booleanAttributeName];
508508
return ko.computed(() => {
509509
let enabled = ModelEditHelper.getDerivedValue(fieldObservable.observable());
510-
if (enabled === undefined && enableOnUndefined) {
510+
if (isUndefined(enabled) && enableOnUndefined) {
511511
enabled = true;
512512
}
513513
return !enabled;
514514
});
515515
};
516+
517+
function isUndefined(value) {
518+
return (value === undefined) || (value === null);
519+
}
516520
}
517521

518522
// return a singleton instance

0 commit comments

Comments
 (0)