From b18e37ec04651fb17278eb4da657c63a7a1b98b2 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 31 Dec 2025 12:10:31 +0100 Subject: [PATCH] Fix PHP 7.4 build There was 1 error: 1) PHPStan\Analyser\NodeScopeResolverTest::testFile with data set "tests/PHPStan/Analyser/data/mb-strlen-php73.php" ('/home/runner/work/phpstan-src...73.php') PHPStan\ShouldNotHappenException: Cannot create PHPStan\Type\UnionType with: 1|3|5|6, false /home/runner/work/phpstan-src/phpstan-src/src/Type/UnionType.php:78 /home/runner/work/phpstan-src/phpstan-src/src/Type/UnionType.php:95 /home/runner/work/phpstan-src/phpstan-src/src/Type/Php/MbStrlenFunctionReturnTypeExtension.php:140 /home/runner/work/phpstan-src/phpstan-src/src/Analyser/MutatingScope.php:2568 /home/runner/work/phpstan-src/phpstan-src/src/Analyser/MutatingScope.php:2552 /home/runner/work/phpstan-src/phpstan-src/src/Analyser/MutatingScope.php:924 /home/runner/work/phpstan-src/phpstan-src/src/Testing/TypeInferenceTestCase.php:272 --- src/Type/Php/MbStrlenFunctionReturnTypeExtension.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Type/Php/MbStrlenFunctionReturnTypeExtension.php b/src/Type/Php/MbStrlenFunctionReturnTypeExtension.php index 141e21ff7f..7614786dbf 100644 --- a/src/Type/Php/MbStrlenFunctionReturnTypeExtension.php +++ b/src/Type/Php/MbStrlenFunctionReturnTypeExtension.php @@ -146,7 +146,7 @@ public function getTypeFromFunctionCall( } if (!$this->phpVersion->throwsOnInvalidMbStringEncoding() && in_array(self::UNSUPPORTED_ENCODING, $encodings, true)) { - return new UnionType([$range, new ConstantBooleanType(false)]); + return TypeCombinator::union($range, new ConstantBooleanType(false)); } return $range; }