Makefile

# Doeff Development Makefile
# ===========================
# Centralized commands for development, testing, and linting.

.PHONY: help install sync lint lint-ruff lint-pyright lint-semgrep lint-semgrep-docs lint-doeff lint-packages \
        test test-unit test-e2e test-packages test-all test-spec-audit-sa002 format check pre-commit-install clean \
        install-opencode-spec-gap-tdd

# Default target
help:
	@echo "Doeff Development Commands"
	@echo "=========================="
	@echo ""
	@echo "Setup:"
	@echo "  make install           Install all dependencies (including dev)"
	@echo "  make sync              Install deps + rebuild Rust VM extension"
	@echo "  make pre-commit-install Install pre-commit hooks"
	@echo ""
	@echo "Linting (make lint runs all):"
	@echo "  make lint              Run ALL linters (core + packages)"
	@echo "  make lint-ruff         Run ruff linter"
	@echo "  make lint-pyright      Run pyright type checker"
	@echo "  make lint-semgrep      Run semgrep architectural rules"
	@echo "  make lint-semgrep-docs Check docs for deprecated API patterns"
	@echo "  make lint-doeff        Run doeff-linter (Rust-based)"
	@echo "  make lint-packages     Run lint in all subpackages with Makefiles"
	@echo ""
	@echo "Testing:"
	@echo "  make test              Run core tests"
	@echo "  make test-unit         Run unit tests only (exclude e2e)"
	@echo "  make test-e2e          Run e2e tests only"
	@echo "  make test-packages     Run tests in all subpackages"
	@echo "  make test-all          Run ALL tests (core + packages)"
	@echo "  make test-spec-audit-sa002 Run SA-002 pytest + semgrep checks"
	@echo ""
	@echo "Formatting:"
	@echo "  make format            Format code with ruff"
	@echo "  make check             Run format check without modifying files"
	@echo ""
	@echo "Utilities:"
	@echo "  make clean             Remove build artifacts and caches"
	@echo "  make install-opencode-spec-gap-tdd Install OpenCode spec-gap-tdd symlinks"

# =============================================================================
# Setup
# =============================================================================

install:
	uv sync --group dev

# Sync dependencies AND rebuild the Rust VM extension.
# ALWAYS use this instead of bare `uv sync` when Rust sources changed.
sync:
	uv sync --group dev
	cd packages/doeff-vm && maturin develop --release

pre-commit-install:
	uv run pre-commit install

# =============================================================================
# Linting - Architectural Enforcement
# =============================================================================

# Run ALL linters (core + packages)
lint: lint-pyright lint-semgrep lint-doeff lint-packages
	@echo ""
	@echo "All linters passed!"

# Ruff: Fast Python linter (style, imports, common issues)
lint-ruff:
	@echo "Running ruff..."
	uv run ruff check doeff/ tests/ packages/

# Pyright: Type checking
lint-pyright:
	@echo "Running pyright..."
	uv run pyright doeff/

# Semgrep: Architectural pattern enforcement
# Install semgrep with: uv tool install semgrep
lint-semgrep:
	@echo "Running semgrep architectural rules..."
	@if command -v semgrep >/dev/null 2>&1; then \
		semgrep --config .semgrep.yaml doeff/ packages/ --error; \
	else \
		echo "Warning: semgrep not installed. Install with: uv tool install semgrep"; \
		exit 1; \
	fi

# Semgrep: Check docs for deprecated Runtime/Runner API usage
lint-semgrep-docs:
	@echo "Running semgrep on documentation..."
	@if command -v semgrep >/dev/null 2>&1; then \
		semgrep --config .semgrep.yaml docs/ README.md --error; \
	else \
		echo "Warning: semgrep not installed. Install with: uv tool install semgrep"; \
		exit 1; \
	fi

# Doeff-linter: Custom Rust-based linter for doeff patterns
lint-doeff:
	@echo "Running doeff-linter..."
	@if command -v doeff-linter >/dev/null 2>&1; then \
		doeff-linter doeff/ packages/; \
	else \
		echo "Warning: doeff-linter not installed."; \
		echo "Build with: cd packages/doeff-linter && cargo install --path ."; \
	fi

# Run lint in all subpackages that have Makefiles
lint-packages:
	@echo "Running lint in subpackages..."
	@for dir in packages/*/; do \
		if [ -f "$$dir/Makefile" ]; then \
			echo ""; \
			echo "=== Linting $$(basename $$dir) ==="; \
			$(MAKE) -C "$$dir" lint || exit 1; \
		fi; \
	done

# =============================================================================
# Testing
# =============================================================================

PYTEST_MEM_GUARD_MB ?= 8192
PYTEST_MEM_GUARD_POLL_INTERVAL ?= 1.0
PYTEST_MEMORY_ENV := PYTEST_MEM_GUARD_MB=$(PYTEST_MEM_GUARD_MB) \
	PYTEST_MEM_GUARD_POLL_INTERVAL=$(PYTEST_MEM_GUARD_POLL_INTERVAL)

test:
	$(PYTEST_MEMORY_ENV) uv run pytest

test-unit:
	$(PYTEST_MEMORY_ENV) uv run pytest -m "not e2e and not slow"

test-e2e:
	$(PYTEST_MEMORY_ENV) uv run pytest -m "e2e"

# Run tests in all subpackages that have tests/ directories
test-packages:
	@echo "Running tests in subpackages..."
	@for dir in packages/*/; do \
		if [ -d "$$dir/tests" ]; then \
			echo ""; \
			echo "=== Testing $$(basename $$dir) ==="; \
			(cd "$$dir" && uv run pytest tests/) || exit 1; \
		fi; \
	done

# Run ALL tests: core + all subpackages
test-all: test test-packages
	@echo ""
	@echo "All tests passed!"

test-spec-audit-sa002:
	uv run pytest tests/core/test_sa002_spec_gaps.py
	@if command -v semgrep >/dev/null 2>&1; then \
		semgrep --config specs/audits/SA-002/semgrep/rules.yml doeff/ packages/; \
	else \
		echo "Warning: semgrep not installed. Install with: uv tool install semgrep"; \
		exit 1; \
	fi

# =============================================================================
# Formatting
# =============================================================================

format:
	uv run ruff format doeff/ tests/ packages/
	uv run ruff check --fix doeff/ tests/ packages/

check:
	uv run ruff format --check doeff/ tests/ packages/
	uv run ruff check doeff/ tests/ packages/

# =============================================================================
# Utilities
# =============================================================================

clean:
	rm -rf .pytest_cache .ruff_cache .mypy_cache __pycache__
	rm -rf dist build *.egg-info
	find . -type d -name "__pycache__" -exec rm -rf {} + 2>/dev/null || true
	find . -type f -name "*.pyc" -delete 2>/dev/null || true

install-opencode-spec-gap-tdd:
	bash scripts/install-opencode-spec-gap-tdd.sh