From 8549d55ca1100e7a2a56d63707b57b9b07169744 Mon Sep 17 00:00:00 2001
From: avilacarlosdev <avilavaleriocarlos@gmail.com>
Date: Sat, 9 May 2026 19:36:51 -0400
Subject: [PATCH] fix: default icons to aria-hidden

---
 icon-sprite/src/_shared.tsx                   |  1 +
 icon-sprite/tests/run-all-tests.js            |  5 +++
 .../tests/test-accessibility-props.test.js    | 32 +++++++++++++++++++
 3 files changed, 38 insertions(+)
 create mode 100644 icon-sprite/tests/test-accessibility-props.test.js

diff --git a/icon-sprite/src/_shared.tsx b/icon-sprite/src/_shared.tsx
index f3afbc74..f6049b3f 100644
--- a/icon-sprite/src/_shared.tsx
+++ b/icon-sprite/src/_shared.tsx
@@ -23,6 +23,7 @@ export type IconProps = React.SVGProps<SVGSVGElement> & {
 export function renderUse(id: string, path: string, { size, width, height, style, strokeWidth, ...rest }: IconProps) {
 	return (
 		<svg
+			aria-hidden="true"
 			{...rest}
 			width={width ?? size ?? 24}
 			height={height ?? size ?? 24}
diff --git a/icon-sprite/tests/run-all-tests.js b/icon-sprite/tests/run-all-tests.js
index 63b3e60d..1db2831e 100644
--- a/icon-sprite/tests/run-all-tests.js
+++ b/icon-sprite/tests/run-all-tests.js
@@ -23,6 +23,11 @@ const testSuites = [
 		file: "test-sprite-id-match.test.js",
 		description: "Verify sprite IDs in wrappers match build-sprite mapping",
 	},
+	{
+		name: "Accessibility Props Tests",
+		file: "test-accessibility-props.test.js",
+		description: "Verify default aria-hidden behavior and consumer overrides",
+	},
 	{
 		name: "Config Loading Tests",
 		file: "test-config.test.js",
diff --git a/icon-sprite/tests/test-accessibility-props.test.js b/icon-sprite/tests/test-accessibility-props.test.js
new file mode 100644
index 00000000..941972ff
--- /dev/null
+++ b/icon-sprite/tests/test-accessibility-props.test.js
@@ -0,0 +1,32 @@
+#!/usr/bin/env node
+/**
+ * Test: sprite-rendered icons match Lucide React's default accessibility behavior.
+ *
+ * Decorative icons should be hidden from assistive technology by default, while
+ * consumers can still override aria-hidden when an icon has semantic meaning.
+ */
+
+process.env.NODE_ENV = "production";
+
+try {
+	const { Activity } = await import("../dist/icons/Activity.js");
+
+	const defaultIcon = Activity({});
+	if (defaultIcon.props["aria-hidden"] !== "true") {
+		throw new Error(`Expected default aria-hidden to be "true", received ${defaultIcon.props["aria-hidden"]}`);
+	}
+
+	const exposedIcon = Activity({ "aria-hidden": "false", role: "img" });
+	if (exposedIcon.props["aria-hidden"] !== "false") {
+		throw new Error(`Expected aria-hidden override to be preserved, received ${exposedIcon.props["aria-hidden"]}`);
+	}
+
+	if (exposedIcon.props.role !== "img") {
+		throw new Error(`Expected role prop to be preserved, received ${exposedIcon.props.role}`);
+	}
+
+	console.log("✅ Default aria-hidden behavior matches lucide-react and remains overrideable.");
+} catch (e) {
+	console.error(`❌ Test failed: ${e.message}`);
+	process.exit(1);
+}