Skip to content

Commit 34af97e

Browse files
coadometa-codesync[bot]
authored andcommitted
Add guards for react/renderer/components/view (#57357) (#57357) (#57357)
Summary: Roll umbrella with umbrella guards for headers under `react/renderer/components/view` subtree. Initially, we assume that the entire target is public, so each header within includes a public umbrella guard. Changelog: [Internal] Pulled By: coado Pull Request resolved: #57357 coado Reviewed By: cipolleschi Differential Revision: D109847184
1 parent a4733b1 commit 34af97e

47 files changed

Lines changed: 174 additions & 0 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

packages/react-native/React/React-RCTFBReactNativeSpec.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ Pod::Spec.new do |s|
6868
add_dependency(ss, "React-debug")
6969
add_dependency(ss, "React-rendererdebug")
7070
add_dependency(ss, "React-utils")
71+
add_dependency(ss, "React-cxxstableapi")
7172
add_dependency(ss, "React-graphics", :additional_framework_paths => ["react/renderer/graphics/platform/ios"])
7273
add_dependency(ss, "React-Fabric", :additional_framework_paths => [
7374
"react/renderer/components/view/platform/cxx",

packages/react-native/React/React-RCTFabric.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ Pod::Spec.new do |s|
100100
add_dependency(s, "React-networking", :framework_name => 'React_networking')
101101
add_dependency(s, "React-renderercss")
102102
add_dependency(s, "React-RCTFBReactNativeSpec")
103+
add_dependency(s, "React-cxxstableapi")
103104

104105
depend_on_js_engine(s)
105106
add_rn_third_party_dependencies(s)

packages/react-native/ReactAndroid/build.gradle.kts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,10 @@ val preparePrefab by
172172
"../ReactCommon/react/renderer/components/view/",
173173
"react/renderer/components/view/",
174174
),
175+
Pair(
176+
"../ReactCommon/react/renderer/components/view/React/",
177+
"React/",
178+
),
175179
Pair("../ReactCommon/react/renderer/components/view/platform/android/", ""),
176180
// rrc_root
177181
Pair(

packages/react-native/ReactCommon/React-Fabric.podspec

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ Pod::Spec.new do |s|
4242
s.dependency "React-logger"
4343
s.dependency "React-Core"
4444
s.dependency "React-debug"
45+
s.dependency "React-cxxstableapi"
4546
s.dependency "React-featureflags"
4647
s.dependency "React-runtimescheduler"
4748
s.dependency "React-cxxreact"
@@ -138,6 +139,12 @@ Pod::Spec.new do |s|
138139
sss.header_dir = "react/renderer/components/view"
139140
end
140141

142+
ss.subspec "viewUmbrella" do |sss|
143+
sss.source_files = "react/renderer/components/view/React/*.h"
144+
sss.header_dir = "React"
145+
sss.header_mappings_dir = "react/renderer/components/view/React"
146+
end
147+
141148
ss.subspec "scrollview" do |sss|
142149
sss.source_files = podspec_sources("react/renderer/components/scrollview/**/*.{m,mm,cpp,h}", "react/renderer/components/scrollview/**/*.{h}")
143150
sss.header_dir = "react/renderer/components/scrollview"

packages/react-native/ReactCommon/react/renderer/components/view/AccessibilityPrimitives.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <cinttypes>
1113
#include <optional>
1214
#include <string>

packages/react-native/ReactCommon/react/renderer/components/view/AccessibilityProps.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <react/renderer/components/view/AccessibilityPrimitives.h>
1113
#include <react/renderer/core/Props.h>
1214
#include <react/renderer/core/PropsParserContext.h>

packages/react-native/ReactCommon/react/renderer/components/view/BackgroundImagePropsConversions.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <react/featureflags/ReactNativeFeatureFlags.h>
1113
#include <react/renderer/core/PropsParserContext.h>
1214
#include <react/renderer/core/RawProps.h>

packages/react-native/ReactCommon/react/renderer/components/view/BaseTouch.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <jsi/jsi.h>
1113
#include <react/renderer/core/ReactPrimitives.h>
1214
#include <react/renderer/debug/DebugStringConvertible.h>

packages/react-native/ReactCommon/react/renderer/components/view/BaseViewEventEmitter.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <memory>
1113
#include <mutex>
1214

packages/react-native/ReactCommon/react/renderer/components/view/BaseViewProps.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <react/renderer/components/view/AccessibilityProps.h>
1113
#include <react/renderer/components/view/YogaStylableProps.h>
1214
#include <react/renderer/components/view/primitives.h>

0 commit comments

Comments
 (0)