Skip to content

Commit a80a4cb

Browse files
j-piaseckifacebook-github-bot
authored andcommitted
Cover hermes/inspector-modern:chrome with Stable API guards (#57978)
Summary: Classifies `hermes/inspector-modern:chrome` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to all three headers in the module and declares the guard dependency in the build config. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D116283495
1 parent 6c4cf29 commit a80a4cb

5 files changed

Lines changed: 8 additions & 0 deletions

File tree

packages/react-native/ReactCommon/hermes/React-hermes.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ Pod::Spec.new do |s|
4848
add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
4949
add_dependency(s, "React-oscompat")
5050
add_dependency(s, "React-jsitooling", :framework_name => "JSITooling")
51+
s.dependency "React-cxxstableapi"
5152

5253
add_rn_third_party_dependencies(s)
5354
add_rncore_dependency(s)

packages/react-native/ReactCommon/hermes/inspector-modern/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,5 @@ target_link_libraries(hermes_inspector_modern
3131
hermes-engine::hermesvm
3232
jsi
3333
jsinspector
34+
react_cxxstableapi
3435
${reactnative})

packages/react-native/ReactCommon/hermes/inspector-modern/chrome/HermesRuntimeAgentDelegate.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#ifdef HERMES_ENABLE_DEBUGGER
1113

1214
#include "HermesRuntimeTargetDelegate.h"

packages/react-native/ReactCommon/hermes/inspector-modern/chrome/HermesRuntimeSamplingProfileSerializer.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <hermes/hermes.h>
1113

1214
#include <jsinspector-modern/tracing/RuntimeSamplingProfile.h>

packages/react-native/ReactCommon/hermes/inspector-modern/chrome/HermesRuntimeTargetDelegate.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <ReactCommon/RuntimeExecutor.h>
1113

1214
#include <cxxreact/MessageQueueThread.h>

0 commit comments

Comments
 (0)