fresh binding should shadow the def after expand

Author: bvanjoi

compiler/rustc_resolve/src/ident.rs

@@ -330,7 +330,9 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
 
             module = match rib.kind {
                 RibKind::Module(module) => module,
-                RibKind::MacroDefinition(def) if def == self.macro_def(ident.span.ctxt()) => {
+                RibKind::MacroDefinition(def) | RibKind::LookAheadMacroDefinition(def)
+                    if def == self.macro_def(ident.span.ctxt()) =>
+                {
                     // If an invocation of this macro created `ident`, give up on `ident`
                     // and switch to `ident`'s source from the macro definition.
                     ident.span.remove_mark();
@@ -1165,6 +1167,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
                         | RibKind::FnOrCoroutine
                         | RibKind::Module(..)
                         | RibKind::MacroDefinition(..)
+                        | RibKind::LookAheadMacroDefinition(..)
                         | RibKind::ForwardGenericParamBan(_) => {
                             // Nothing to do. Continue.
                         }
@@ -1257,6 +1260,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
                         | RibKind::FnOrCoroutine
                         | RibKind::Module(..)
                         | RibKind::MacroDefinition(..)
+                        | RibKind::LookAheadMacroDefinition(..)
                         | RibKind::InlineAsmSym
                         | RibKind::AssocItem
                         | RibKind::ForwardGenericParamBan(_) => {
@@ -1350,6 +1354,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
                         | RibKind::FnOrCoroutine
                         | RibKind::Module(..)
                         | RibKind::MacroDefinition(..)
+                        | RibKind::LookAheadMacroDefinition(..)
                         | RibKind::InlineAsmSym
                         | RibKind::AssocItem
                         | RibKind::ForwardGenericParamBan(_) => continue,

compiler/rustc_resolve/src/late.rs

@@ -103,7 +103,7 @@ impl IntoDiagArg for PatternSource {
 /// Denotes whether the context for the set of already bound bindings is a `Product`
 /// or `Or` context. This is used in e.g., `fresh_binding` and `resolve_pattern_inner`.
 /// See those functions for more information.
-#[derive(PartialEq)]
+#[derive(PartialEq, Debug)]
 enum PatBoundCtx {
     /// A product pattern context, e.g., `Variant(a, b)`.
     Product,
@@ -217,6 +217,41 @@ pub(crate) enum RibKind<'ra> {
     /// We passed through a `macro_rules!` statement
     MacroDefinition(DefId),
 
+    /// Collects `macro_rules!` statements prior to resolution.
+    /// For example:
+    ///
+    /// ```ignore (illustrative)
+    /// let f = || -> i16 { 42 };       // <1>
+    /// let a: i16 = m!();              // <2>
+    /// macro_rules! m {() => ( f() )}  // <3>
+    /// use m;                          // <4>
+    /// ```
+    ///
+    /// We record `<1>` when resolving the value of `<2>` (the expansion
+    /// result of `<3>`), enabling the system to recognize that `<1>` is
+    /// referenced in `<3>`.
+    ///
+    /// ### Why Not Use `MacroDefinition` Directly?
+    ///
+    /// This prevents edge cases like:
+    ///
+    /// ```ignore (illustrative)
+    /// fn f() {
+    ///     let x = 0;              // <1>
+    ///     macro_rules! foo {
+    ///         () => {
+    ///             assert_eq!(x, 0);
+    ///         }
+    ///     }
+    ///     let x = 1;              // <2>
+    ///     foo!();
+    /// }
+    /// ```
+    ///
+    /// Using `MacroDefinition` would incorrectly record both `<1>` and `<2>` as
+    /// potential resolutions for `x` within the macro, leading to assertion failed.
+    LookAheadMacroDefinition(DefId),
+
     /// All bindings in this rib are generic parameters that can't be used
     /// from the default of a generic parameter because they're not declared
     /// before said generic parameter. Also see the `visit_generics` override.
@@ -247,6 +282,7 @@ impl RibKind<'_> {
             | RibKind::ConstantItem(..)
             | RibKind::Module(_)
             | RibKind::MacroDefinition(_)
+            | RibKind::LookAheadMacroDefinition(_)
             | RibKind::InlineAsmSym => false,
             RibKind::ConstParamTy
             | RibKind::AssocItem
@@ -258,7 +294,9 @@ impl RibKind<'_> {
     /// This rib forbids referring to labels defined in upwards ribs.
     fn is_label_barrier(self) -> bool {
         match self {
-            RibKind::Normal | RibKind::MacroDefinition(..) => false,
+            RibKind::Normal
+            | RibKind::MacroDefinition(..)
+            | RibKind::LookAheadMacroDefinition(..) => false,
 
             RibKind::AssocItem
             | RibKind::FnOrCoroutine
@@ -3791,17 +3829,21 @@ impl<'a, 'ast, 'ra, 'tcx> LateResolutionVisitor<'a, 'ast, 'ra, 'tcx> {
 
     /// Apply the bindings from a pattern to the innermost rib of the current scope.
     fn apply_pattern_bindings(&mut self, mut pat_bindings: PatternBindings) {
-        let rib_bindings = self.innermost_rib_bindings(ValueNS);
         let Some((_, pat_bindings)) = pat_bindings.pop() else {
             bug!("tried applying nonexistent bindings from pattern");
         };
-
-        if rib_bindings.is_empty() {
-            // Often, such as for match arms, the bindings are introduced into a new rib.
-            // In this case, we can move the bindings over directly.
-            *rib_bindings = pat_bindings;
-        } else {
-            rib_bindings.extend(pat_bindings);
+        for rib in self.ribs[ValueNS].iter_mut().rev() {
+            let stop = !matches!(rib.kind, RibKind::LookAheadMacroDefinition(_));
+            if rib.bindings.is_empty() {
+                // Often, such as for match arms, the bindings are introduced into a new rib.
+                // In this case, we can move the bindings over directly.
+                rib.bindings = pat_bindings.clone();
+            } else {
+                rib.bindings.extend(pat_bindings.clone());
+            }
+            if stop {
+                break;
+            }
         }
     }
 
@@ -4673,6 +4715,15 @@ impl<'a, 'ast, 'ra, 'tcx> LateResolutionVisitor<'a, 'ast, 'ra, 'tcx> {
         }
 
         // Descend into the block.
+        for stmt in &block.stmts {
+            if let StmtKind::Item(ref item) = stmt.kind
+                && let ItemKind::MacroDef(..) = item.kind
+            {
+                let res = self.r.local_def_id(item.id).to_def_id();
+                self.ribs[ValueNS].push(Rib::new(RibKind::LookAheadMacroDefinition(res)));
+            }
+        }
+
         for stmt in &block.stmts {
             if let StmtKind::Item(ref item) = stmt.kind
                 && let ItemKind::MacroDef(..) = item.kind
@@ -4689,6 +4740,8 @@ impl<'a, 'ast, 'ra, 'tcx> LateResolutionVisitor<'a, 'ast, 'ra, 'tcx> {
         // Move back up.
         self.parent_scope.module = orig_module;
         for _ in 0..num_macro_definition_ribs {
+            // pop `LookAheadMacroDefinition` and `MacroDefinition`
+            self.ribs[ValueNS].pop();
             self.ribs[ValueNS].pop();
             self.label_ribs.pop();
         }

tests/ui/resolve/fresh-should-shadow-definitation-in-decl-macro-expand.rs

@@ -0,0 +1,191 @@
+//@ check-pass
+//@ edition:2018
+// issue#95237
+
+
+#![feature(decl_macro)]
+
+type FnF = i8;
+type LetF = i16;
+
+fn f_without_definition_f() {
+    let f = || -> LetF { 42 };
+    let a: LetF = m!();
+    macro m() { f() }
+}
+
+fn f_without_closure_f() {
+    fn f() -> FnF { 42 }
+    let a: FnF = m!();
+    macro m() { f() }
+}
+
+fn f0() {
+    let f = || -> LetF { 42 };
+    fn f() -> FnF { 42 }
+    let a: LetF = m!();
+    macro m() { f() }
+}
+
+fn f1() {
+    let f = || -> LetF { 42 };
+    let a: LetF = m!();
+    fn f() -> FnF { 42 }
+    macro m() { f() }
+}
+
+fn f2() {
+    let f = || -> LetF { 42 };
+    let a: LetF = m!();
+    macro m() { f() }
+    fn f() -> FnF { 42 }
+}
+
+fn f3() {
+    let f = || -> LetF { 42 };
+    macro m() { f() }
+    let a: LetF = m!();
+    fn f() -> FnF { 42 }
+}
+
+fn f4() {
+    let f = || -> LetF { 42 };
+    macro m() { f() }
+    fn f() -> FnF { 42 }
+    let a: LetF = m!();
+}
+
+fn f5() {
+    let f = || -> LetF { 42 };
+    fn f() -> FnF { 42 }
+    macro m() { f() }
+        let a: LetF = m!();
+}
+
+fn f6() {
+    fn f() -> FnF { 42 }
+    let f = || -> LetF { 42 };
+    let a: LetF = m!();
+    macro m() { f() }
+}
+
+fn f7() {
+    fn f() -> FnF { 42 }
+    let f = || -> LetF { 42 };
+    macro m() { f() }
+    let a: LetF = m!();
+}
+
+fn f8() {
+    fn f() -> FnF { 42 }
+    let a: FnF = m!();
+    let f = || -> LetF { 42 };
+    macro m() { f() }
+}
+
+fn f9() {
+    fn f() -> FnF { 42 }
+    let a: FnF = m!();
+    macro m() { f() }
+    let f = || -> LetF { 42 };
+}
+
+fn f10() {
+    fn f() -> FnF { 42 }
+    macro m() { f() }
+    let a: FnF = m!();
+    let f = || -> LetF { 42 };
+}
+
+fn f11() {
+    fn f() -> FnF { 42 }
+    macro m() { f() }
+    let f = || -> LetF { 42 };
+    let a: FnF = m!();
+}
+
+fn f12() {
+    let a: FnF = m!();
+    fn f() -> FnF { 42 }
+    let f = || -> LetF { 42 };
+    macro m() { f() }
+}
+
+fn f13() {
+    let a: FnF = m!();
+    let f = || -> LetF { 42 };
+    fn f() -> FnF { 42 }
+    macro m() { f() }
+}
+
+fn f14() {
+    let a: FnF = m!();
+    let f = || -> LetF { 42 };
+    macro m() { f() }
+    fn f() -> FnF { 42 }
+}
+
+fn f15() {
+    let a: FnF = m!();
+    macro m() { f() }
+    let f = || -> LetF { 42 };
+    fn f() -> FnF { 42 }
+}
+
+fn f16() {
+    let a: FnF = m!();
+    macro m() { f() }
+    fn f() -> FnF { 42 }
+    let f = || -> LetF { 42 };
+}
+
+fn f17() {
+    let a: FnF = m!();
+    fn f() -> FnF { 42 }
+    macro m() { f() }
+    let f = || -> LetF { 42 };
+}
+
+fn f18() {
+    macro m() { f() }
+    let a: FnF = m!();
+    fn f() -> FnF { 42 }
+    let f = || -> LetF { 42 };
+}
+
+fn f19() {
+    macro m() { f() }
+    fn f() -> FnF { 42 }
+    let a: FnF = m!();
+    let f = || -> LetF { 42 };
+}
+
+fn f20() {
+    macro m() { f() }
+    fn f() -> FnF { 42 }
+    let f = || -> LetF { 42 };
+    let a: FnF = m!();
+}
+
+fn f21() {
+    macro m() { f() }
+    let a: FnF = m!();
+    let f = || -> LetF { 42 };
+    fn f() -> FnF { 42 }
+}
+
+fn f22() {
+    macro m() { f() }
+    let f = || -> LetF { 42 };
+    fn f() -> FnF { 42 }
+    let a: FnF = m!();
+}
+
+fn f23() {
+    macro m() { f() }
+    let f = || -> LetF { 42 };
+    let a: FnF = m!();
+    fn f() -> FnF { 42 }
+}
+
+fn main () {}