-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
Move compile-pass tests to check-pass or build-pass #62277
Copy link
Copy link
Closed
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.Call for participation: Medium difficulty. Experience needed to fix: Intermediate.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.Call for participation: Medium difficulty. Experience needed to fix: Intermediate.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
compile-passwas the old way to assert that UI tests were able to successfully build. However, it would do a full build of the code, including codegen and linking. Many of our tests don't need this, however, and should instead use the newcheck-pass, introduced in #61778. For tests that exercise codegen and linking,build-passcan be used instead.As a first step, it would be good to remove
compile-passto prevent users adding new tests that unconsciously take a dependency on codegen/linking, and push them to usecheck/build-passto make the distinction explicit.To do this, we'd like to start with a mass migration of
compile-passtests tobuild-pass(rather thancheck-passbecause we don't want to accidentally stop testing codegen/linking functionality). However, we don't want to lose the distinction between tests which are intentionallybuild-passand those that have been automatically migrated, so automatically-migrated tests should include a note like// build-pass (FIXME(this-issue-#): could be check-pass?)or similar.Once that's done, we can remove
compile-passand work on moving over theFIXME-tagged tests to eithercheck-passor remove theFIXME.