-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Track stderr color in UI tests #88254
Copy link
Copy link
Open
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.
Metadata
Metadata
Assignees
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Disclaimer: the whole idea comes from @estebank on twitter (link). I'm just summarizing it here.
Now that we can emit super-fancy colored suggestions (PR #86532), it would be a good idea to track the color of the messages we emit for some special cases in the ui tests.
A good way to track the color of each character would be to generate an HTML file per test. This would be both human-friendly (reviewers can open the resulting HTML file on their browser) and testing framework-friendly (as every character color is tracked, we can spot regressions).
As suggested in the original tweet, explicit coloring can be triggered with a
// generate-htmlheader command. We can also add a-Zflag so that users can use it outside of rustc tests.As a new rust-lang/rust contributor, I'd love to work on that, but I need some ideas of how to track colors from experienced rustc developers first.
Edits: