raise AuthenticationError on failed login

Author: jlwalke2

CHANGELOG.md

@@ -9,6 +9,7 @@ Unreleased
 
  **Improvements**
  - Added `copy_analytic_store` method to `model_repository` service
+ - `AuthenticationError` returned instead of `HTTPError` if session authentication fails. 
 
 
 v0.9.7 (2019-07-18)

src/sasctl/core.py

@@ -484,11 +484,29 @@ def _get_token_with_password(self):
                                       data=data,
                                       headers=headers,
                                       auth=('sas.ec', ''))
-        r.raise_for_status()
+
+        if r.status_code == 401:
+            raise AuthenticationError("Authentication failed for user '%s'." % username)
+        else:
+            r.raise_for_status()
 
         return r.json().get('access_token')
 
     def get_token(self):
+        """Authenticates with the session host and retrieves an
+        authorization token for use by subsequent requests.
+
+        Returns
+        -------
+        str
+            a bearer token for :class:`HTTPBearerAuth`
+
+        Raises
+        ------
+        AuthenticationError
+            authentication with the host failed
+
+        """
         username = self._settings['username']
         password = self._settings['password']
 
@@ -888,3 +906,6 @@ class SasctlError(Exception):
 
 class TimeoutError(SasctlError):
     pass
+
+class AuthenticationError(SasctlError):
+    pass

tests/unit/test_session.py

@@ -218,7 +218,6 @@ def test_ssl_context():
 
 
 def test_verify_ssl():
-
     with mock.patch('sasctl.core.Session.get_token', return_value='token'):
         # Should verify SSL by default
         s = Session('hostname', 'username', 'password')
@@ -261,3 +260,13 @@ def test_kerberos():
 
         s = Session('hostname', 'username@REALM')
         assert s.auth.token == 'token'
+
+def test_authentication_failure():
+    from sasctl.core import AuthenticationError
+
+    with mock.patch('sasctl.core.Session.request') as request:
+        request.return_value.status_code = 401
+
+        with pytest.raises(AuthenticationError):
+            Session('hostname', 'username', 'password')
+