Improve FLAC channel count validation#927
Merged
Merged
Conversation
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v22.1.7
Click here for the full clang-format patch
diff --git a/Sources/CSFBAudioEngine/Decoders/SFBFLACDecoder.mm b/Sources/CSFBAudioEngine/Decoders/SFBFLACDecoder.mm
index 2e370c6..c9cf23c 100644
--- a/Sources/CSFBAudioEngine/Decoders/SFBFLACDecoder.mm
+++ b/Sources/CSFBAudioEngine/Decoders/SFBFLACDecoder.mm
@@ -596,3 +596,4 @@ void errorCallback(const FLAC__StreamDecoder *decoder, FLAC__StreamDecoderErrorS
- unsupportedFormatError:NSLocalizedString(@"FLAC", @"")
- recoverySuggestion:NSLocalizedString(@"Channel count mismatch between STREAMINFO and first frame header.",
- @"")];
+ unsupportedFormatError:NSLocalizedString(@"FLAC", @"")
+ recoverySuggestion:NSLocalizedString(
+ @"Channel count mismatch between STREAMINFO and first frame header.",
+ @"")];
Have any feedback or feature suggestions? Share it here.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines FLAC channel-count validation in SFBFLACDecoder by moving the STREAMINFO vs frame-header channel check to only trigger on the first decoded frame, aiming to avoid repeated per-frame validation while still catching invalid streams early.
Changes:
- Removed per-frame STREAMINFO vs frame-header channel validation.
- Added a STREAMINFO vs first frame-header channel validation with a more specific error message.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.