fix: replace set_over with_extremes#562
Merged
Merged
Conversation
nvaytet
reviewed
May 21, 2026
| @@ -68,15 +70,19 @@ def _get_cmap(colormap: str | Colormap, nan_color: str | None = None) -> Colorma | |||
Member
There was a problem hiding this comment.
I think that because we now return new objects, we no longer need this copy here?
nvaytet
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the nightly test failures here: https://github.com/scipp/plopp/actions/runs/25536713387/job/74953922444
I'm not sure this is exactly equivalent to the old implementation.
For example, in some cases we create new objects instead of mutating, I assumed that doesn't make a difference here, but maybe it does?