monitor: reserve runners internally #96
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the beginning of our CI system, even before the monitor had an API (servo/servo#33315), we’ve reserved runners by adding labels to those runners in the GitHub API. this is slow and sometimes fragile, and it will not work on Forgejo Actions (#94), where labels are defined at registration time and redefined when starting the runner.
this patch makes the monitor store reservations internally. we also rework how we label runners such that runners are uniquely identifiable at registration time, rather than only at reservation time:
self-hostedis unchangedX64is removed, since it was unused and contradicts UTM-based servo-macos15-arm profile #64self-hosted-image:<profile>is nowself-hosted-profile:<profile>and computed automaticallyself-hosted-runner:<name>@<host>is new, and uniquely identifies the runnerself-hosted-uuid:<runner uuid>is new, and uniquely identifies the runnerwhen the runner-select action successfully reserves a runner, we set
runs-ontoself-hosted-uuid:<runner uuid>, rather thanreserved-for:<job unique id>.test runs: