stuff

Author: sezanzeb

inputremapper/bin/input_remapper_gtk.py

@@ -29,6 +29,8 @@
 
 import gi
 
+from inputremapper.bin.process_utils import ProcessUtils
+
 gi.require_version("Gtk", "3.0")
 gi.require_version("GLib", "2.0")
 gi.require_version("GtkSource", "4")
@@ -109,6 +111,12 @@ def main() -> Tuple[
     # by the user.
     reader_client = ReaderClient(message_broker, _Groups())
 
+    if ProcessUtils.count_python_processes("input-remapper-gtk") >= 2:
+        logger.warning(
+            "Another input-remapper GUI is already running. "
+            "This can cause problems while recording keys"
+        )
+
     if not options.without_reader_service:
         try:
             ReaderService.pkexec_reader_service()

inputremapper/bin/input_remapper_reader_service.py

@@ -25,9 +25,12 @@
 import os
 import signal
 import sys
+import time
 from argparse import ArgumentParser
 
+from inputremapper.bin.process_utils import ProcessUtils
 from inputremapper.groups import _Groups
+from inputremapper.gui.reader_service import ReaderService
 from inputremapper.injection.global_uinputs import GlobalUInputs, FrontendUInput
 from inputremapper.logging.logger import logger
 
@@ -47,8 +50,19 @@ def main() -> None:
 
     logger.update_verbosity(options.debug)
 
-    # import input-remapper stuff after setting the log verbosity
-    from inputremapper.gui.reader_service import ReaderService
+    if ProcessUtils.count_python_processes("input-remapper-reader-service") >= 2:
+        logger.warning(
+            "Another input-remapper-reader-service process is already running. "
+            "This can cause problems while recording keys"
+        )
+
+    if os.getuid() != 0:
+        logger.warning("The reader-service usually needs elevated privileges")
+
+    if not ReaderService.pipes_exist():
+        while not ReaderService.pipes_exist():
+            time.sleep(1)
+            logger.debug("Waiting for pipes to be created")
 
     def on_exit():
         """Don't remain idle and alive when the GUI exits via ctrl+c."""

inputremapper/bin/process_utils.py

@@ -0,0 +1,20 @@
+import psutil
+
+
+class ProcessUtils:
+    @staticmethod
+    def count_python_processes(name: str) -> int:
+        # This is somewhat complicated, because there might also be a "sudo <name>"
+        # process.
+        count = 0
+        pids = psutil.pids()
+        for pid in pids:
+            try:
+                process = psutil.Process(pid)
+                cmdline = process.cmdline()
+                if len(cmdline) >= 2 and "python" in cmdline[0] and name in cmdline[1]:
+                    count += 1
+            except Exception:
+                pass
+
+        return count

inputremapper/gui/reader_client.py

@@ -45,7 +45,6 @@
     CMD_TERMINATE,
     CMD_REFRESH_GROUPS,
     CMD_STOP_READING,
-    get_pipe_paths,
     ReaderService,
 )
 from inputremapper.gui.utils import CTX_ERROR
@@ -120,8 +119,8 @@ def _send_command(self, command: str):
 
     def connect(self):
         """Connect to the reader-service."""
-        results_pipe = Pipe(get_pipe_paths()[0])
-        commands_pipe = Pipe(get_pipe_paths()[1])
+        results_pipe = Pipe(ReaderService.get_pipe_paths()[0])
+        commands_pipe = Pipe(ReaderService.get_pipe_paths()[1])
         return results_pipe, commands_pipe
 
     def attach_to_events(self):

inputremapper/gui/reader_service.py

@@ -46,7 +46,7 @@
 import sys
 import time
 from collections import defaultdict
-from typing import Set, List
+from typing import Set, List, Tuple
 
 import evdev
 from evdev.ecodes import EV_KEY, EV_ABS, EV_REL, REL_HWHEEL, REL_WHEEL
@@ -80,14 +80,6 @@
 MSG_STATUS = "status"
 
 
-def get_pipe_paths():
-    """Get the path where the pipe can be found."""
-    return (
-        f"/tmp/input-remapper-{UserUtils.home}/reader-results",
-        f"/tmp/input-remapper-{UserUtils.home}/reader-commands",
-    )
-
-
 class ReaderService:
     """Service that only reads events and is supposed to run as root.
 
@@ -114,13 +106,13 @@ class ReaderService:
     _maximum_lifetime: int = 60 * 15
     _timeout_tolerance: int = 60
 
-    def __init__(self, groups: _Groups, global_uinputs: GlobalUInputs):
+    def __init__(self, groups: _Groups, global_uinputs: GlobalUInputs) -> None:
         """Construct the reader-service and initialize its communication pipes."""
         self._start_time = time.time()
         self.groups = groups
         self.global_uinputs = global_uinputs
-        self._results_pipe = Pipe(get_pipe_paths()[0])
-        self._commands_pipe = Pipe(get_pipe_paths()[1])
+        self._results_pipe = Pipe(self.get_pipe_paths()[0])
+        self._commands_pipe = Pipe(self.get_pipe_paths()[1])
         self._pipe = multiprocessing.Pipe()
 
         self._tasks: Set[asyncio.Task] = set()
@@ -129,7 +121,24 @@ def __init__(self, groups: _Groups, global_uinputs: GlobalUInputs):
         self._results_pipe.send({"type": MSG_STATUS, "message": "ready"})
 
     @staticmethod
-    def is_running():
+    def get_pipe_paths() -> Tuple[str, str]:
+        """Get the path where the pipe can be found."""
+        return (
+            f"/tmp/input-remapper-{UserUtils.home}/reader-results",
+            f"/tmp/input-remapper-{UserUtils.home}/reader-commands",
+        )
+
+    @staticmethod
+    def pipes_exist() -> bool:
+        # Just checking for one of the 4 files (results, commands both read and write)
+        # should be enough I guess.
+        path = f"{ReaderService.get_pipe_paths()[0]}r"
+        # Use os.path.exists, not lexists or islink, because broken links are bad.
+        # New pipes and symlinks need to be made.
+        return os.path.exists(path)
+
+    @staticmethod
+    def is_running() -> bool:
         """Check if the reader-service is running."""
         try:
             subprocess.check_output(["pgrep", "-f", "input-remapper-reader-service"])