Commit 94a1524
SK-3037 fix module-split fallout in the test and spellcheck setup
Two failures on this PR, both from the common/v2/flowvault split rather than
from the delete and tokenize work; each reproduces on the base branch.
Tests: Dotenv resolves .env against the JVM working directory, which Surefire
sets to the module basedir. CI writes one .env at the repo root, visible to
every test when the build was a single module and to none of them since, so all
five Dotenv-backed test classes failed - and because common builds first, the
reactor died before v2 or flowvault ran. Copy the root .env into each module at
process-test-resources. Repointing Surefire's working directory instead was
tried and rejected: twelve BearerToken and SignedDataTokens tests locate
fixtures by module-relative paths like ./src/test/resources/notJson.txt.
Spellcheck: the generated-code ignore path was root-relative
(src/main/java/com/skyflow/generated/**) so it stopped matching anything after
the split, exposing Fern output - Okio, Googleprotobuf, Googlerpc and an
"opertions" typo carried in from the API spec. Anchor it with **/ instead.
Dictionary gains siom (the japicmp plugin groupId), vaultid and recordss (both
existing identifiers in insert and detokenize code), and synthesise, deserialise
and unmodelled, matching the serialise and normalise entries already there.
Reworded "dedup" and replaced an opaque captured test value.
cspell now reports 0 issues; common passes 172 tests where it previously failed
at TokenTests. The three remaining ConnectionClientTests failures are unrelated
and pre-existing - they need the real SKYFLOW_CREDENTIALS secret.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent cc148fb commit 94a1524
4 files changed
Lines changed: 52 additions & 7 deletions
File tree
- flowvault/src/test/java/com/skyflow/utils
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
102 | | - | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
103 | 111 | | |
104 | 112 | | |
105 | 113 | | |
| |||
119 | 127 | | |
120 | 128 | | |
121 | 129 | | |
122 | | - | |
| 130 | + | |
123 | 131 | | |
124 | 132 | | |
125 | 133 | | |
| |||
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
| 79 | + | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
| 103 | + | |
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1058 | 1058 | | |
1059 | 1059 | | |
1060 | 1060 | | |
1061 | | - | |
| 1061 | + | |
1062 | 1062 | | |
1063 | 1063 | | |
1064 | 1064 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
148 | 185 | | |
149 | 186 | | |
150 | 187 | | |
| |||
0 commit comments