You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SK-2832: fix severity taxonomy in PR review (Quality is advisory, not blocking)
The Step 1 legend marked Quality as "fix before merge" (blocking) while the
consolidated CI output bucketed Quality as non-blocking, so a Quality finding
landed in the blocking table while the "Non-blocking (Quality/Smell)" section
reported 0 — contradictory output.
- Step 1 legend: Quality is now explicitly "No — advisory" (Critical/Bug/Edge
remain blocking).
- Output (PR/CI mode): add one authoritative severity split — Blocking =
Critical/Bug/Edge/High/Medium; Advisory = Quality/Smell/Low/Info — drive the
verdict from blocking only, forbid advisory rows in the blocking table, and
rename the collapsed section to "Advisory (Quality / Smell / Low / Info)".
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@@ -92,19 +92,23 @@ After all three steps, close with:
92
92
93
93
## Output (PR / CI mode)
94
94
95
-
When `GITHUB_ACTIONS` is set, **do not** print the three steps' standalone tables/summaries/verdicts. Merge every finding from Steps 1–3 into a single de-duplicated report (if the same issue is flagged by more than one step, keep it once with the highest severity). Emit **exactly** the following, and nothing else:
95
+
When `GITHUB_ACTIONS` is set, **do not** print the three steps' standalone tables/summaries/verdicts. Merge every finding from Steps 1–3 into a single de-duplicated report (if the same issue is flagged by more than one step, keep it once with the highest severity). Emit **exactly** the following, and nothing else.
96
96
97
-
1.**One-line verdict** — `APPROVE` / `APPROVE WITH FIXES` / `REQUEST CHANGES`, followed by a one-sentence rationale.
97
+
**Severity buckets (single source of truth for this mode — every finding is exactly one):**
-**Advisory** (does not block merge): `Quality`, `Smell`, `Low`, `Info`.
98
100
99
-
2.**One blocking-findings table** (Critical / Bug / Edge Case / High / Medium only). Omit the table entirely if there are none and say "No blocking findings on the changed lines."
101
+
1.**One-line verdict** — `REQUEST CHANGES` if there is **≥1 blocking** finding; `APPROVE WITH FIXES` if there are only advisory findings; `APPROVE` if there are none. Add a one-sentence rationale.
102
+
103
+
2.**Blocking-findings table** — blocking severities only. A `Quality` / `Smell` / `Low` / `Info` finding must **never** appear here. Omit the table and say "No blocking findings on the changed lines." if there are none.
0 commit comments