From f0423407a0a42843e1a2602138a47835ee324a71 Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 15 Jul 2025 11:47:55 -0700 Subject: [PATCH 01/22] Redo CMake --- CMakeLists.txt | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 CMakeLists.txt diff --git a/CMakeLists.txt b/CMakeLists.txt new file mode 100644 index 0000000..21e14ff --- /dev/null +++ b/CMakeLists.txt @@ -0,0 +1,41 @@ +cmake_minimum_required(VERSION 3.14) +project(sac LANGUAGES CXX) + +set(CMAKE_CXX_STANDARD 23) +set(CMAKE_CXX_STANDARD_REQUIRED ON) +set(CMAKE_CXX_EXTENSIONS OFF) + +file(GLOB_RECURSE SOURCES CONFIGURE_DEPENDS src/*.cpp) + +add_executable(sac ${SOURCES}) + +option(ENABLE_AVX256 "AVX2/FMA" OFF) +option(ENABLE_AVX512 "AVX512" OFF) + +if(ENABLE_AVX512) + target_compile_options(sac PRIVATE + -mavx512f + -mavx512dq + -mavx512bw + -mavx512vl + -mfma + -O3 + ) + target_compile_definitions(sac PRIVATE USE_AVX512=1) +elseif(ENABLE_AVX256) + target_compile_options(sac PRIVATE + -mavx2 + -mfma + -O3 + ) + target_compile_definitions(sac PRIVATE USE_AVX256=1) +else() + target_compile_options(sac PRIVATE + -O3 + ) + target_compile_definitions(sac PRIVATE) +endif() + +target_link_libraries(sac PRIVATE stdc++) + +set(CMAKE_EXPORT_COMPILE_COMMANDS ON) From 483a53acc8c036da2366ea5dc51b8d4704b2c244 Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 15 Jul 2025 11:49:24 -0700 Subject: [PATCH 02/22] Std fix --- src/common/md5.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/common/md5.h b/src/common/md5.h index f61d72e..40a73ea 100644 --- a/src/common/md5.h +++ b/src/common/md5.h @@ -1,6 +1,7 @@ #ifndef MD5_H #define MD5_H +#include #include namespace MD5 { From bbdbf938040a99ceef3f1cfe0686a2f00c3fdf17 Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 15 Jul 2025 16:00:23 -0700 Subject: [PATCH 03/22] Update CMakeLists.txt --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 21e14ff..152636c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -9,7 +9,7 @@ file(GLOB_RECURSE SOURCES CONFIGURE_DEPENDS src/*.cpp) add_executable(sac ${SOURCES}) -option(ENABLE_AVX256 "AVX2/FMA" OFF) +option(ENABLE_AVX2 "AVX2/FMA" OFF) option(ENABLE_AVX512 "AVX512" OFF) if(ENABLE_AVX512) From 636305fd3beead383615df1ede9ba9ca6e4a6e47 Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 15 Jul 2025 16:04:03 -0700 Subject: [PATCH 04/22] Whoops --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 152636c..c96e2e7 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -22,7 +22,7 @@ if(ENABLE_AVX512) -O3 ) target_compile_definitions(sac PRIVATE USE_AVX512=1) -elseif(ENABLE_AVX256) +elseif(ENABLE_AVX2) target_compile_options(sac PRIVATE -mavx2 -mfma From 39db23ad00309ffcaf25024a1d58a3f90f47ac38 Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 12:42:27 -0700 Subject: [PATCH 05/22] CMake Build test --- .github/workflows/cmake-multi-platform.yml | 75 ++++++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 .github/workflows/cmake-multi-platform.yml diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml new file mode 100644 index 0000000..f21a025 --- /dev/null +++ b/.github/workflows/cmake-multi-platform.yml @@ -0,0 +1,75 @@ +# This starter workflow is for a CMake project running on multiple platforms. There is a different starter workflow if you just want a single platform. +# See: https://github.com/actions/starter-workflows/blob/main/ci/cmake-single-platform.yml +name: CMake on multiple platforms + +on: + push: + branches: [ "master" ] + pull_request: + branches: [ "master" ] + +jobs: + build: + runs-on: ${{ matrix.os }} + + strategy: + # Set fail-fast to false to ensure that feedback is delivered for all matrix combinations. Consider changing this to true when your workflow is stable. + fail-fast: false + + # Set up a matrix to run the following 3 configurations: + # 1. + # 2. + # 3. + # + # To add more build types (Release, Debug, RelWithDebInfo, etc.) customize the build_type list. + matrix: + os: [ubuntu-latest, windows-latest] + build_type: [Release] + c_compiler: [gcc, clang, cl] + include: + - os: windows-latest + c_compiler: cl + cpp_compiler: cl + - os: ubuntu-latest + c_compiler: gcc + cpp_compiler: g++ + - os: ubuntu-latest + c_compiler: clang + cpp_compiler: clang++ + exclude: + - os: windows-latest + c_compiler: gcc + - os: windows-latest + c_compiler: clang + - os: ubuntu-latest + c_compiler: cl + + steps: + - uses: actions/checkout@v4 + + - name: Set reusable strings + # Turn repeated input strings (such as the build output directory) into step outputs. These step outputs can be used throughout the workflow file. + id: strings + shell: bash + run: | + echo "build-output-dir=${{ github.workspace }}/build" >> "$GITHUB_OUTPUT" + + - name: Configure CMake + # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make. + # See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type + run: > + cmake -B ${{ steps.strings.outputs.build-output-dir }} + -DCMAKE_CXX_COMPILER=${{ matrix.cpp_compiler }} + -DCMAKE_C_COMPILER=${{ matrix.c_compiler }} + -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} + -S ${{ github.workspace }} + + - name: Build + # Build your program with the given configuration. Note that --config is needed because the default Windows generator is a multi-config generator (Visual Studio generator). + run: cmake --build ${{ steps.strings.outputs.build-output-dir }} --config ${{ matrix.build_type }} + + - name: Test + working-directory: ${{ steps.strings.outputs.build-output-dir }} + # Execute tests defined by the CMake configuration. Note that --build-config is needed because the default Windows generator is a multi-config generator (Visual Studio generator). + # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail + run: ctest --build-config ${{ matrix.build_type }} From 85623b2a1b2ab46453800789df3c3fa609dd082c Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 12:45:05 -0700 Subject: [PATCH 06/22] CMake Action AVX2 --- .github/workflows/cmake-multi-platform.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index f21a025..6a97df7 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -62,6 +62,7 @@ jobs: -DCMAKE_CXX_COMPILER=${{ matrix.cpp_compiler }} -DCMAKE_C_COMPILER=${{ matrix.c_compiler }} -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} + -DENABLE_AVX2=ON -S ${{ github.workspace }} - name: Build From ef83dea192901f50a780276048af7273ebdbeeb3 Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 12:48:20 -0700 Subject: [PATCH 07/22] Try and fix build gcc --- src/common/utils.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/common/utils.h b/src/common/utils.h index 6d42b9d..76d5a37 100644 --- a/src/common/utils.h +++ b/src/common/utils.h @@ -5,10 +5,11 @@ #include "math.h" #include -#include #include #include +#include #include +#include // running exponential smoothing // sum=alpha*sum+(1.0-alpha)*val, where 1/(1-alpha) is the mean number of samples considered From 03c49e5b16aedca9db296e943bf2d8744175bc29 Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 12:57:58 -0700 Subject: [PATCH 08/22] MinGW --- .github/workflows/cmake-multi-platform.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index 6a97df7..b79b465 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -1,6 +1,12 @@ # This starter workflow is for a CMake project running on multiple platforms. There is a different starter workflow if you just want a single platform. # See: https://github.com/actions/starter-workflows/blob/main/ci/cmake-single-platform.yml name: CMake on multiple platforms +uses: egor-tensin/setup-mingw@v2 + with: + platform: x64 + cygwin: 0 + static: 0 + cc: 0 on: push: @@ -28,8 +34,8 @@ jobs: c_compiler: [gcc, clang, cl] include: - os: windows-latest - c_compiler: cl - cpp_compiler: cl + c_compiler: x86_64-w64-mingw32-gcc + cpp_compiler: x86_64-w64-mingw32-g++ - os: ubuntu-latest c_compiler: gcc cpp_compiler: g++ From ec281d00a99faaa3c51050e22f22e78f3211ac71 Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 13:00:04 -0700 Subject: [PATCH 09/22] Error --- .github/workflows/cmake-multi-platform.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index b79b465..c560aab 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -1,12 +1,6 @@ # This starter workflow is for a CMake project running on multiple platforms. There is a different starter workflow if you just want a single platform. # See: https://github.com/actions/starter-workflows/blob/main/ci/cmake-single-platform.yml name: CMake on multiple platforms -uses: egor-tensin/setup-mingw@v2 - with: - platform: x64 - cygwin: 0 - static: 0 - cc: 0 on: push: From 70714b14a82f6bedae5292a9a65803d15d0a42ee Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 13:04:35 -0700 Subject: [PATCH 10/22] Update cmake-multi-platform.yml --- .github/workflows/cmake-multi-platform.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index c560aab..f70203b 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -24,8 +24,7 @@ jobs: # To add more build types (Release, Debug, RelWithDebInfo, etc.) customize the build_type list. matrix: os: [ubuntu-latest, windows-latest] - build_type: [Release] - c_compiler: [gcc, clang, cl] + c_compiler: [gcc, clang, x86_64-w64-mingw32-gcc] include: - os: windows-latest c_compiler: x86_64-w64-mingw32-gcc @@ -61,7 +60,7 @@ jobs: cmake -B ${{ steps.strings.outputs.build-output-dir }} -DCMAKE_CXX_COMPILER=${{ matrix.cpp_compiler }} -DCMAKE_C_COMPILER=${{ matrix.c_compiler }} - -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} + -DCMAKE_BUILD_TYPE=Release -DENABLE_AVX2=ON -S ${{ github.workspace }} From 4e6b9762a2d2cf6f20454cc129d70bbb36529136 Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 13:07:09 -0700 Subject: [PATCH 11/22] Update cmake-multi-platform.yml --- .github/workflows/cmake-multi-platform.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index f70203b..9531c43 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -26,7 +26,7 @@ jobs: os: [ubuntu-latest, windows-latest] c_compiler: [gcc, clang, x86_64-w64-mingw32-gcc] include: - - os: windows-latest + - os: ubuntu-latest c_compiler: x86_64-w64-mingw32-gcc cpp_compiler: x86_64-w64-mingw32-g++ - os: ubuntu-latest From a7b3832600d12d1cabbd48fda5e0dc2f98290351 Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 13:07:56 -0700 Subject: [PATCH 12/22] Install MinGW --- .github/workflows/cmake-multi-platform.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index 9531c43..fddad6a 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -2,6 +2,10 @@ # See: https://github.com/actions/starter-workflows/blob/main/ci/cmake-single-platform.yml name: CMake on multiple platforms +run: | + sudo apt-get update + sudo apt-get install -y mingw-w64 + on: push: branches: [ "master" ] From e014d51194d3cc40269329668a8b455e1618cc9a Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 13:10:20 -0700 Subject: [PATCH 13/22] Update cmake-multi-platform.yml --- .github/workflows/cmake-multi-platform.yml | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index fddad6a..e161e87 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -2,10 +2,6 @@ # See: https://github.com/actions/starter-workflows/blob/main/ci/cmake-single-platform.yml name: CMake on multiple platforms -run: | - sudo apt-get update - sudo apt-get install -y mingw-w64 - on: push: branches: [ "master" ] @@ -27,7 +23,7 @@ jobs: # # To add more build types (Release, Debug, RelWithDebInfo, etc.) customize the build_type list. matrix: - os: [ubuntu-latest, windows-latest] + os: [ubuntu-latest] c_compiler: [gcc, clang, x86_64-w64-mingw32-gcc] include: - os: ubuntu-latest @@ -39,15 +35,14 @@ jobs: - os: ubuntu-latest c_compiler: clang cpp_compiler: clang++ - exclude: - - os: windows-latest - c_compiler: gcc - - os: windows-latest - c_compiler: clang - - os: ubuntu-latest - c_compiler: cl steps: + - name: Install MinGW-w64 + #Installs MinGW + run: | + sudo apt-get update + sudo apt-get install -y mingw-w64 + - uses: actions/checkout@v4 - name: Set reusable strings From 20de68df80e29fcea6858ee3b3bd1bebe93b2ab8 Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 13:12:21 -0700 Subject: [PATCH 14/22] Whoops - See if this works --- .github/workflows/cmake-multi-platform.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index e161e87..0af1858 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -59,7 +59,7 @@ jobs: cmake -B ${{ steps.strings.outputs.build-output-dir }} -DCMAKE_CXX_COMPILER=${{ matrix.cpp_compiler }} -DCMAKE_C_COMPILER=${{ matrix.c_compiler }} - -DCMAKE_BUILD_TYPE=Release + -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DENABLE_AVX2=ON -S ${{ github.workspace }} From d67596195792161fad2c54f89d4d6de1c6f07e2e Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 13:14:07 -0700 Subject: [PATCH 15/22] Update cmake-multi-platform.yml --- .github/workflows/cmake-multi-platform.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index 0af1858..a3af37f 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -23,6 +23,7 @@ jobs: # # To add more build types (Release, Debug, RelWithDebInfo, etc.) customize the build_type list. matrix: + build_type: Release os: [ubuntu-latest] c_compiler: [gcc, clang, x86_64-w64-mingw32-gcc] include: From 20d2d7f52b1f37dca3e72c68a5698aae57853819 Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 13:15:33 -0700 Subject: [PATCH 16/22] Brackets --- .github/workflows/cmake-multi-platform.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index a3af37f..26ee250 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -23,7 +23,7 @@ jobs: # # To add more build types (Release, Debug, RelWithDebInfo, etc.) customize the build_type list. matrix: - build_type: Release + build_type: [Release] os: [ubuntu-latest] c_compiler: [gcc, clang, x86_64-w64-mingw32-gcc] include: From 06dfdbde2a57f4fab119c091a738b91a77ab560d Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 13:22:14 -0700 Subject: [PATCH 17/22] Just get rid of windows builds entirely, that's for later. --- .github/workflows/cmake-multi-platform.yml | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index 26ee250..b3521b9 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -25,11 +25,8 @@ jobs: matrix: build_type: [Release] os: [ubuntu-latest] - c_compiler: [gcc, clang, x86_64-w64-mingw32-gcc] + c_compiler: [gcc, clang] include: - - os: ubuntu-latest - c_compiler: x86_64-w64-mingw32-gcc - cpp_compiler: x86_64-w64-mingw32-g++ - os: ubuntu-latest c_compiler: gcc cpp_compiler: g++ @@ -38,12 +35,6 @@ jobs: cpp_compiler: clang++ steps: - - name: Install MinGW-w64 - #Installs MinGW - run: | - sudo apt-get update - sudo apt-get install -y mingw-w64 - - uses: actions/checkout@v4 - name: Set reusable strings From 1a182753806dc55561157bd737268385c59557d7 Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 13:31:15 -0700 Subject: [PATCH 18/22] Artifacts v1 --- .github/workflows/cmake-multi-platform.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index b3521b9..ff4ca6b 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -64,3 +64,11 @@ jobs: # Execute tests defined by the CMake configuration. Note that --build-config is needed because the default Windows generator is a multi-config generator (Visual Studio generator). # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail run: ctest --build-config ${{ matrix.build_type }} + - name: Upload a Build Artifact + uses: actions/upload-artifact@v4.6.2 + with: + name: sac + path: ./sac + if-no-files-found: warn + overwrite: false + include-hidden-files: false From 45f7369b0dd4356029095bf34de26b10222c5e68 Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 13:31:50 -0700 Subject: [PATCH 19/22] Artifacts v1 fix --- .github/workflows/cmake-multi-platform.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index ff4ca6b..a0154f0 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -65,10 +65,10 @@ jobs: # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail run: ctest --build-config ${{ matrix.build_type }} - name: Upload a Build Artifact - uses: actions/upload-artifact@v4.6.2 - with: - name: sac - path: ./sac - if-no-files-found: warn - overwrite: false - include-hidden-files: false + uses: actions/upload-artifact@v4.6.2 + with: + name: sac + path: ./sac + if-no-files-found: warn + overwrite: false + include-hidden-files: false From c36e25a2981998eeb60695d59318d815dee01ceb Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 13:34:43 -0700 Subject: [PATCH 20/22] Build dir --- .github/workflows/cmake-multi-platform.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index a0154f0..412c6c0 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -68,7 +68,7 @@ jobs: uses: actions/upload-artifact@v4.6.2 with: name: sac - path: ./sac + path: ./build/ if-no-files-found: warn overwrite: false include-hidden-files: false From 055d6c6dccc21757b38f241515bacabcffd5ec89 Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 13:48:31 -0700 Subject: [PATCH 21/22] Clang fix??? --- src/common/alignbuf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/alignbuf.h b/src/common/alignbuf.h index df0a85c..a5cb601 100644 --- a/src/common/alignbuf.h +++ b/src/common/alignbuf.h @@ -23,7 +23,7 @@ struct align_alloc { } void deallocate(T* p, std::size_t n) noexcept { - ::operator delete(p, n * sizeof(T), std::align_val_t(align_t)); + ::operator delete(p, std::align_val_t(align_t)); } }; From aa225e6a88b8e5c0c922e294c2bc9edbf7fed235 Mon Sep 17 00:00:00 2001 From: Autumn Ives <146475002+lpn256@users.noreply.github.com> Date: Tue, 29 Jul 2025 13:51:13 -0700 Subject: [PATCH 22/22] Overwrite build --- .github/workflows/cmake-multi-platform.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index 412c6c0..c3de66c 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -70,5 +70,5 @@ jobs: name: sac path: ./build/ if-no-files-found: warn - overwrite: false + overwrite: true include-hidden-files: false