Skip to content

Commit 9165521

Browse files
Merge pull request #180 from splitio/fix-sonar
Fix CI and SonarQube
2 parents df7c19a + 78b424a commit 9165521

21 files changed

Lines changed: 671 additions & 2642 deletions

.github/workflows/ci-cd.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ on:
88
branches:
99
- '*'
1010

11+
env:
12+
PUPPETEER_SKIP_DOWNLOAD: 'true'
13+
1114
concurrency:
1215
group: ${{ github.workflow }}-${{ github.event_name == 'push' && github.run_number || github.event.pull_request.number }}
1316
cancel-in-progress: true
@@ -33,6 +36,13 @@ jobs:
3336
- name: npm ci
3437
run: npm ci
3538

39+
- name: Setup Chrome
40+
uses: browser-actions/setup-chrome@19ae4b339ee18925ab85cf12c1041150ea4a44c8 # v1
41+
with:
42+
chrome-version: '125'
43+
- name: Set CHROME_BIN
44+
run: echo "CHROME_BIN=$(which chrome)" >> $GITHUB_ENV
45+
3646
- name: npm test-ts-decls
3747
run: npm run test-ts-decls
3848

.github/workflows/sonar-scan.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
-Dsonar.links.scm="https://github.com/splitio/${{ github.event.repository.name }}"
5050
5151
- name: SonarQube Scan (Pull Request)
52-
if: github.event_name == 'pull_request'
52+
if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository
5353
uses: SonarSource/sonarqube-scan-action@v6
5454
env:
5555
SONAR_TOKEN: ${{ secrets.SONARQUBE_TOKEN }}

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,4 +116,3 @@ dist
116116
/.idea
117117

118118
.DS_Store
119-
/karma/bundle.js

karma/config.debug.js

Lines changed: 0 additions & 22 deletions
This file was deleted.

karma/config.js

Lines changed: 0 additions & 99 deletions
This file was deleted.

karma/e2e.consumer.karma.conf.js

Lines changed: 0 additions & 21 deletions
This file was deleted.

karma/e2e.destroy.karma.conf.js

Lines changed: 0 additions & 20 deletions
This file was deleted.

karma/e2e.errorCatching.karma.conf.js

Lines changed: 0 additions & 20 deletions
This file was deleted.

karma/e2e.logger.karma.conf.js

Lines changed: 0 additions & 20 deletions
This file was deleted.

karma/e2e.offline.karma.conf.js

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)