more explicit error message for dgpy.plug argument issues

thanks @jviereck

Author: nim65s

src/dynamic_graph/dynamic-graph-py.cc

@@ -49,7 +49,8 @@ PyObject* plug(
   if (signalIn == NULL) {
       struct module_state* st = GETSTATE(m);
       std::ostringstream oss;
-      oss << "dgpy.plug in argument must be a dynamic_graph.Signal, not a " << PyCapsule_GetName(objIn);
+      oss << "dynamic_graph.plug(a, b): Argument 'b' must be of type 'dynamic_graph.Signal', but got "
+          << PyCapsule_GetName(objIn);
       PyErr_SetString(st->dgpyError, oss.str().c_str());
       return NULL;
   }
@@ -58,7 +59,8 @@ PyObject* plug(
   if (signalOut == NULL) {
       struct module_state* st = GETSTATE(m);
       std::ostringstream oss;
-      oss << "dgpy.plug out argument must be a dynamic_graph.Signal, not a " << PyCapsule_GetName(objOut);
+      oss << "dynamic_graph.plug(a, b): Argument 'a' must be of type 'dynamic_graph.Signal', but got "
+          << PyCapsule_GetName(objOut);
       PyErr_SetString(st->dgpyError, oss.str().c_str());
       return NULL;
   }

unitTesting/test_bindings.py

@@ -4,6 +4,8 @@
 
 from custom_entity import CustomEntity
 
+ERR = "dynamic_graph.plug(a, b): Argument '%s' must be of type 'dynamic_graph.Signal', but got dynamic_graph.Entity"
+
 
 class BindingsTests(unittest.TestCase):
     def test_bindings(self):
@@ -20,14 +22,12 @@ def test_type_check(self):
         # Check that we can't connect first.out to second
         with self.assertRaises(dg.dgpyError) as cm_in:
             dg.plug(first.signal('out_double'), second)
-        self.assertEqual(str(cm_in.exception),
-                         "dgpy.plug in argument must be a dynamic_graph.Signal, not a dynamic_graph.Entity")
+        self.assertEqual(str(cm_in.exception), ERR % 'b')
 
         # Check that we can't connect first to second.in
         with self.assertRaises(dg.dgpyError) as cm_out:
             dg.plug(first, second.signal('in_double'))
-        self.assertEqual(str(cm_out.exception),
-                         "dgpy.plug out argument must be a dynamic_graph.Signal, not a dynamic_graph.Entity")
+        self.assertEqual(str(cm_out.exception), ERR % 'a')
 
 
 if __name__ == '__main__':