fix: add preset VFS config file to avoid TOML parsing errors (#3414)

Author: sxyazi

yazi-config/preset/vfs-default.toml

@@ -0,0 +1 @@
+[services]

yazi-config/src/preset.rs

@@ -1,4 +1,4 @@
-use crate::{Yazi, keymap::Keymap, theme::Theme};
+use crate::{Yazi, keymap::Keymap, theme::Theme, vfs::Vfs};
 
 pub(crate) struct Preset;
 
@@ -19,6 +19,10 @@ impl Preset {
 		})
 	}
 
+	pub(super) fn vfs() -> Result<Vfs, toml::de::Error> {
+		toml::from_str(&yazi_macro::config_preset!("vfs"))
+	}
+
 	#[inline]
 	pub(crate) fn mix<E, A, B, C>(a: A, b: B, c: C) -> impl Iterator<Item = E>
 	where

yazi-config/src/vfs/mod.rs

@@ -1 +1 @@
-yazi_macro::mod_flat!(service vfs);
+yazi_macro::mod_flat!(service services vfs);

yazi-config/src/vfs/services.rs

@@ -0,0 +1,42 @@
+use std::ops::Deref;
+
+use anyhow::{Result, bail};
+use hashbrown::HashMap;
+use serde::{Deserialize, Serialize};
+
+use crate::vfs::Service;
+
+#[derive(Deserialize, Serialize)]
+pub struct Services(HashMap<String, Service>);
+
+impl Deref for Services {
+	type Target = HashMap<String, Service>;
+
+	fn deref(&self) -> &Self::Target { &self.0 }
+}
+
+impl Services {
+	pub(super) fn reshape(mut self) -> Result<Self> {
+		for (name, service) in &mut self.0 {
+			if name.is_empty() || name.len() > 20 {
+				bail!("VFS name `{name}` must be between 1 and 20 characters");
+			} else if !name.bytes().all(|b| matches!(b, b'0'..=b'9' | b'a'..=b'z' | b'-')) {
+				bail!("VFS name `{name}` must be in kebab-case");
+			}
+
+			service.reshape()?;
+		}
+
+		Ok(self)
+	}
+
+	pub(super) fn deserialize_over<'de, D>(mut self, deserializer: D) -> Result<Self, D::Error>
+	where
+		D: serde::Deserializer<'de>,
+	{
+		let map: HashMap<String, Service> = HashMap::deserialize(deserializer)?;
+		self.0.extend(map);
+
+		Ok(self)
+	}
+}

yazi-config/src/vfs/vfs.rs

@@ -1,16 +1,17 @@
 use std::io;
 
-use hashbrown::HashMap;
+use anyhow::{Context, Result};
 use serde::{Deserialize, Serialize};
 use tokio::sync::OnceCell;
-use yazi_fs::Xdg;
-use yazi_macro::ok_or_not_found;
+use yazi_codegen::DeserializeOver1;
+use yazi_fs::{Xdg, ok_or_not_found};
 
 use super::Service;
+use crate::{Preset, vfs::Services};
 
-#[derive(Deserialize, Serialize)]
+#[derive(Deserialize, Serialize, DeserializeOver1)]
 pub struct Vfs {
-	pub services: HashMap<String, Service>,
+	pub services: Services,
 }
 
 impl Vfs {
@@ -19,9 +20,10 @@ impl Vfs {
 
 		async fn init() -> io::Result<Vfs> {
 			tokio::task::spawn_blocking(|| {
-				toml::from_str::<Vfs>(&Vfs::read()?).map_err(io::Error::other)?.reshape()
+				Preset::vfs()?.deserialize_over(toml::Deserializer::parse(&Vfs::read()?)?)?.reshape()
 			})
 			.await?
+			.map_err(|e| io::Error::new(io::ErrorKind::Other, e))
 		}
 
 		LOADED.get_or_try_init(init).await
@@ -40,24 +42,11 @@ impl Vfs {
 		}
 	}
 
-	fn read() -> io::Result<String> {
+	fn read() -> Result<String> {
 		let p = Xdg::config_dir().join("vfs.toml");
-		Ok(ok_or_not_found!(std::fs::read_to_string(&p).map_err(|e| {
-			std::io::Error::new(e.kind(), format!("Failed to read VFS config {p:?}: {e}"))
-		})))
+		ok_or_not_found(std::fs::read_to_string(&p))
+			.with_context(|| format!("Failed to read config {p:?}"))
 	}
 
-	fn reshape(mut self) -> io::Result<Self> {
-		for (name, service) in &mut self.services {
-			if name.is_empty() || name.len() > 20 {
-				Err(io::Error::other(format!("VFS name `{name}` must be between 1 and 20 characters")))?;
-			} else if !name.bytes().all(|b| matches!(b, b'0'..=b'9' | b'a'..=b'z' | b'-')) {
-				Err(io::Error::other(format!("VFS name `{name}` must be in kebab-case")))?;
-			}
-
-			service.reshape()?;
-		}
-
-		Ok(self)
-	}
+	fn reshape(self) -> Result<Self> { Ok(Self { services: self.services.reshape()? }) }
 }

yazi-scheduler/src/file/file.rs

@@ -119,14 +119,12 @@ impl File {
 		.await?;
 
 		if !links.is_empty() {
-			let len = links.len();
-			let (tx, mut rx) = mpsc::channel(len);
+			let (tx, mut rx) = mpsc::channel(1);
 			for task in links {
 				self.queue(task.with_drop(&tx), LOW);
 			}
-			for _ in 0..len {
-				rx.recv().await;
-			}
+			drop(tx);
+			while rx.recv().await.is_some() {}
 		}
 
 		for task in files {

yazi-scheduler/src/file/in.rs

@@ -42,11 +42,7 @@ pub(crate) struct FileInCut {
 }
 
 impl Drop for FileInCut {
-	fn drop(&mut self) {
-		if let Some(tx) = self.drop.take() {
-			tx.try_send(()).ok();
-		}
-	}
+	fn drop(&mut self) { _ = self.drop.take(); }
 }
 
 impl FileInCut {

yazi-shared/src/loc/buf.rs

@@ -266,24 +266,24 @@ mod tests {
 	#[test]
 	fn test_new() {
 		let loc: LocBuf = Path::new("/").into();
-		assert_eq!(loc.uri().as_os_str(), OsStr::new("/"));
+		assert_eq!(loc.uri().as_os_str(), OsStr::new(""));
 		assert_eq!(loc.urn().as_os_str(), OsStr::new(""));
 		assert_eq!(loc.file_name(), None);
-		assert_eq!(loc.base().as_os_str(), OsStr::new(""));
+		assert_eq!(loc.base().as_os_str(), OsStr::new("/"));
 		assert_eq!(loc.trail().as_os_str(), OsStr::new("/"));
 
 		let loc: LocBuf = Path::new("/root").into();
-		assert_eq!(loc.uri().as_os_str(), OsStr::new("/root"));
+		assert_eq!(loc.uri().as_os_str(), OsStr::new("root"));
 		assert_eq!(loc.urn().as_os_str(), OsStr::new("root"));
 		assert_eq!(loc.file_name().unwrap(), OsStr::new("root"));
-		assert_eq!(loc.base().as_os_str(), OsStr::new(""));
+		assert_eq!(loc.base().as_os_str(), OsStr::new("/"));
 		assert_eq!(loc.trail().as_os_str(), OsStr::new("/"));
 
 		let loc: LocBuf = Path::new("/root/code/foo/").into();
-		assert_eq!(loc.uri().as_os_str(), OsStr::new("/root/code/foo"));
+		assert_eq!(loc.uri().as_os_str(), OsStr::new("foo"));
 		assert_eq!(loc.urn().as_os_str(), OsStr::new("foo"));
 		assert_eq!(loc.file_name().unwrap(), OsStr::new("foo"));
-		assert_eq!(loc.base().as_os_str(), OsStr::new(""));
+		assert_eq!(loc.base().as_os_str(), OsStr::new("/root/code/"));
 		assert_eq!(loc.trail().as_os_str(), OsStr::new("/root/code/"));
 	}
 

yazi-shared/src/loc/loc.rs

@@ -86,7 +86,7 @@ where
 		let path = path.as_path_view();
 		let Some(name) = path.file_name() else {
 			let p = path.strip_prefix(P::empty()).unwrap();
-			return Self { inner: p, uri: p.len(), urn: 0, _phantom: PhantomData };
+			return Self { inner: p, uri: 0, urn: 0, _phantom: PhantomData };
 		};
 
 		let name_len = name.len();
@@ -97,7 +97,7 @@ where
 		let bytes = &path.as_encoded_bytes()[..prefix_len + name_len];
 		Self {
 			inner:    unsafe { P::from_encoded_bytes_unchecked(bytes) },
-			uri:      bytes.len(),
+			uri:      name_len,
 			urn:      name_len,
 			_phantom: PhantomData,
 		}

yazi-shared/src/scheme/cow.rs

@@ -146,7 +146,7 @@ impl<'a> SchemeCow<'a> {
 		Ok(match kind {
 			SchemeKind::Regular => {
 				ensure!(uri.is_none() && urn.is_none(), "Regular scheme cannot have ports");
-				(path.components().count(), path.name().is_some() as usize)
+				(path.name().is_some() as usize, path.name().is_some() as usize)
 			}
 			SchemeKind::Search => {
 				let (uri, urn) = (uri.unwrap_or(0), urn.unwrap_or(0));
@@ -155,15 +155,20 @@ impl<'a> SchemeCow<'a> {
 			}
 			SchemeKind::Archive => (uri.unwrap_or(0), urn.unwrap_or(0)),
 			SchemeKind::Sftp => {
-				let uri = uri.unwrap_or_else(|| path.components().count());
+				let uri = uri.unwrap_or(path.name().is_some() as usize);
 				let urn = urn.unwrap_or(path.name().is_some() as usize);
 				(uri, urn)
 			}
 		})
 	}
 
 	pub fn retrieve_ports(url: Url) -> (usize, usize) {
-		(url.uri().components().count(), url.urn().components().count())
+		match url {
+			Url::Regular(loc) => (loc.file_name().is_some() as usize, loc.file_name().is_some() as usize),
+			Url::Search { loc, .. } => (loc.uri().components().count(), loc.urn().components().count()),
+			Url::Archive { loc, .. } => (loc.uri().components().count(), loc.urn().components().count()),
+			Url::Sftp { loc, .. } => (loc.uri().components().count(), loc.urn().components().count()),
+		}
 	}
 }