Add tests to org.symphonyoss.client.events package

[dayoaws]

Add tests to org.symphonyoss.client.events package which currently has limited number of tests. what's the process for getting access to submit changes. See initial gist https://gist.github.com/dayoaws/f0079a72febcfc128d6996658cbf40af

[ftbb]

You need an ICLA or CCLA to submit changes. See: https://symphonyoss.atlassian.net/wiki/spaces/FM/pages/138117154/Contributing+to+an+Existing+Project

[dayoaws]

got it. submitted one

[copiesofcopies]

@ftbb you're clear to merge PRs from @dayoaws.

[ftbb]

Sorry for the delay in responding, but there seems to be many updates to the code here I will need to review before accepting and potentially some commercial understanding on diffblue.

This software underpins many financial services bots in the market, so we are trying to make sure there are no impacts around these changes being submitted in the pull requests.

With that said, I'm really excited to have new contributors... hope to review shortly.

[dayoaws]

completely understand. happy to come onboard. looking forward to helping out

…

On Fri, Apr 27, 2018 at 11:45 AM, Frank Tarsillo ***@***.***> wrote: Sorry for the delay in responding, but there seems to be many updates to the code here I will need to review before accepting and potentially some commercial understanding on diffblue. This software underpins many financial services bots in the market, so we are trying to make sure there are no impacts around these changes being submitted in the pull requests. With that said, I'm really excited to have new contributors... hope to review shortly. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#115 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABMeN3oSOk9y3W-boOlYsC4B5Jg7M518ks5tsz0ggaJpZM4TVwQA> .

[dayoaws]

Hi Frank - Did you get a chance to take a look?

…

On Fri, Apr 27, 2018 at 6:58 PM, DE FE ***@***.***> wrote: completely understand. happy to come onboard. looking forward to helping out On Fri, Apr 27, 2018 at 11:45 AM, Frank Tarsillo ***@***.*** > wrote: > Sorry for the delay in responding, but there seems to be many updates to > the code here I will need to review before accepting and potentially some > commercial understanding on diffblue. > > This software underpins many financial services bots in the market, so we > are trying to make sure there are no impacts around these changes being > submitted in the pull requests. > > With that said, I'm really excited to have new contributors... hope to > review shortly. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#115 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABMeN3oSOk9y3W-boOlYsC4B5Jg7M518ks5tsz0ggaJpZM4TVwQA> > . >