-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add introspection implementation - updated #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
kromacie
wants to merge
36
commits into
thephpleague:master
from
kromacie:feature/add-introspection-implementation
Closed
Add introspection implementation - updated #1255
kromacie
wants to merge
36
commits into
thephpleague:master
from
kromacie:feature/add-introspection-implementation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to RFC 7662 the introspection mechanism is implemented
…flow Co-authored-by: Rob Taylor <[email protected]>
…feature/add-introspection-implementation-code-review # Conflicts: # src/Grant/AuthCodeGrant.php
The JWT logic has been moved from the introspection response and is now in the child class BearerTokenIntrospectionResponse
…ntation-code-review' into feature/add-introspection-implementation
Contributor
Member
|
My apologies this was never progressed and thank you for your efforts. I think this has inspired the implementation in #1473 which is close to being merged. I'm going to close this in favour of that implementation but thank you very much for your efforts here |
Author
|
@Sephster , all good, inspiring anyone is more that I could expect in that case. Good luck guys :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
There is a PR started by Steve Porter related to RFC 7662 that wasn't updated for almost three years already. Based on the activity under the old thread and my personal willingness to use it, I think that there is still a demand for this feature. Therefore I decided to refurbish it a bit and refactor it slightly.
There is what I changed compared to the previous PR.
Also, It's my very first contribution to an open-source project, so please feel free to mention any mistake or gap that I didn't find. I hope you will find it helpful.