Pass user id from old refresh token to finalizeScopes() #1414
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hafezdivandari
approved these changes
Jul 3, 2024
hafezdivandari
suggested changes
Feb 12, 2025
Contributor
hafezdivandari
left a comment
hafezdivandari
left a comment
There was a problem hiding this comment.
Reflect changes from PR #1436
Contributor
|
@pl-github please merge |
Co-authored-by: Hafez Divandari <[email protected]>
pl-github
force-pushed
the
pass-user-id-to-finalize-scopes
branch
from
f2a832e to
246782c
Compare
Contributor
Author
|
@hafezdivandari I have rebased my branch. What do you mean by "remove redundant code"? |
Contributor
Contributor
Author
|
@hafezdivandari Done 👍 |
hafezdivandari
approved these changes
Feb 14, 2025
Closed
Member
|
Thank you @pl-github and apologies for the delay getting this looked at. It will be included in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the user ID in our
finalizeScopes()implementation to adjust the selection of scopes. As of version 9.0, thefinalizeScopes()method is also called for theRefreshTokenGrant, but the user ID is not currently passed to thefinalizeScopes()method. Since the user ID is in the old refresh token, it can be passed from there.