version attribute is ignored for plugins

[hbugdoll]

@cb1kenobi This is for the transition from node-appc to node-titanium-sdk!

---

lib/timodule.js correctly takes into account the version attribute of a <module> tag.

So, <module platform="iphone" version="99.99.99">ti.map</module> in tiapp.xml gives

[DEBUG] Looking for Titanium module id=ti.map version=99.99.99 platform=ios deploy-type=development
[WARN]  Could not find a valid Titanium module id=ti.map version=99.99.99 platform=ios deploy-type=development
...
[ERROR] Could not find all required Titanium Modules:
[ERROR]    id: ti.map    version: 99.99.99       platform: ios   deploy-type: development

---

But lib/tiplugin.js just passes the version attribute:

node-appc/lib/tiplugin.js

Lines 132 to 151 in c35e794

	logger && logger.debug(__('Looking for Titanium plugin id=%s version=%s', plugin.id.cyan, originalVersion.cyan));
	let found;
	for (let i = 0; !found && i < scopes.length; i++) {
	const scope = installed[scopes[i]];
	if (scope && scope[plugin.id]) {
	const info = scope[plugin.id][plugin.version] || scope[plugin.id]['unknown'] || scope[plugin.id]['-'];
	if (info) {
	util.mix(plugin, info);
	logger && logger.info(__('Found Titanium plugin id=%s version=%s ', plugin.id.cyan, originalVersion.cyan));
	result.found.push(plugin);
	found = true;
	}
	}
	}
	if (!found) {
	logger && logger.warn(__('Could not find Titanium plugin id=%s version=%s', plugin.id.cyan, originalVersion.cyan));
	result.missing.push(plugin);
	}

So, <plugin version="99.99.99">ti.alloy</plugin> results in following false positive log:

[DEBUG] Detecting plugins in /Users/***/kitchensink-v2/plugins
[DEBUG] Detected plugin: ti.alloy @ /Users/***/kitchensink-v2/plugins/ti.alloy
[DEBUG] Looking for Titanium plugin id=ti.alloy version=99.99.99
[INFO]  Found Titanium plugin id=ti.alloy version=99.99.99

The "wrong" plugin version is loaded.

[cb1kenobi]

Hi! The tiplugin.js is effectively dead code. Nothing uses it. The Titanium CLI hasn't depended on node-appc since 7.0.0 shipped May 10, 2024. The Titanium CLI also does not support traditional "plugins". It support "hooks", but they need to be declared in the Titanium CLI config in the paths.hooks. This is how Alloy is loaded.

I could see plugins returning someday, but maybe in the form of npm packages in your project.

[hbugdoll]

Hi Chris, thanks for the clarification.

So, are all the

<plugins>
    <plugin version="1.0">ti.alloy</plugin>
</plugins>

in tiapp.xml now obsolete?

They are still included here:

• titanium-docs/.../guide/Titanium_SDK/Titanium_SDK_Guide/Appendices/tiapp.xml_and_timodule.xml_Reference.md
• hyperloop-examples/.../tiapp.xml
• pulsar-titanium/.../spec/data/fixtures/alloy-project/tiapp.xml

[cb1kenobi]

Yeah, it hasn't worked for almost 2 years. The docs and those repos are out-of-date.

I could see plugin support returning after the library conslidation and CLI parser overhaul. In the meantime, you'll need to manually add the plugin's hooks directory to the CLI config's paths.hooks.