Skip to content

Commit 88ac588

Browse files
committed
fix: preserve zod v4 configuration behavior
1 parent e1e9772 commit 88ac588

4 files changed

Lines changed: 10 additions & 8 deletions

File tree

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ When modifying only server components (`apps/webapp/`, `apps/supervisor/`, etc.)
108108

109109
## Dependency Pinning
110110

111-
Zod is pinned to a single version across the entire monorepo (currently `3.25.76`). When adding zod to a new or existing package, use the **exact same version** as the rest of the repo - never a different version or a range. Mismatched zod versions cause runtime type incompatibilities (e.g., schemas from one package can't be used as body validators in another).
111+
Zod is pinned to a single version across the entire monorepo (currently `4.4.3`). When adding zod to a new or existing package, use the **exact same version** as the rest of the repo - never a different version or a range. Mismatched zod versions cause runtime type incompatibilities (e.g., schemas from one package can't be used as body validators in another).
112112

113113
## Architecture Overview
114114

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables.new/route.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -247,12 +247,14 @@ export default function Page() {
247247
const [selectedEnvironmentIds, setSelectedEnvironmentIds] = useState<Set<string>>(new Set());
248248
const [selectedBranchId, setSelectedBranchId] = useState<string | undefined>(undefined);
249249

250-
const branchEnvironments = environments.filter((env) => env.branchName);
251-
const nonBranchEnvironments = environments.filter((env) => !env.branchName);
252-
const selectedEnvironments = environments.filter((env) => selectedEnvironmentIds.has(env.id));
253-
const previewIsSelected = selectedEnvironments.some(
254-
(env) => env.branchName !== null || env.type === "PREVIEW"
250+
// TODO: we only support branch-specific env vars for Preview environments.
251+
// This keeps setting consistent env vars across Dev/Staging/Prod easier.
252+
const branchEnvironments = environments.filter(
253+
(env) => env.type === "PREVIEW" && env.parentEnvironmentId !== null
255254
);
255+
const nonBranchEnvironments = environments.filter((env) => env.parentEnvironmentId === null);
256+
const selectedEnvironments = environments.filter((env) => selectedEnvironmentIds.has(env.id));
257+
const previewIsSelected = selectedEnvironments.some((env) => env.type === "PREVIEW");
256258

257259
const isLoading = navigation.state !== "idle" && navigation.formMethod === "post";
258260

apps/webapp/app/services/platform.v3.server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ const MachineOverrideValues = z.object({
242242
});
243243
type MachineOverrideValues = z.infer<typeof MachineOverrideValues>;
244244

245-
const MachineOverrides = z.record(MachinePresetName, MachineOverrideValues.partial());
245+
const MachineOverrides = z.partialRecord(MachinePresetName, MachineOverrideValues.partial());
246246
type MachineOverrides = z.infer<typeof MachineOverrides>;
247247

248248
const MachinePresetOverrides = z.object({

internal-packages/dashboard-agent/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"@internal/dashboard-agent-db": "workspace:*",
1515
"@trigger.dev/sdk": "workspace:*",
1616
"ai": "^6.0.116",
17-
"zod": "3.25.76"
17+
"zod": "4.4.3"
1818
},
1919
"devDependencies": {
2020
"@ai-sdk/provider": "3.0.8",

0 commit comments

Comments
 (0)