improve errors

Author: carderne

apps/webapp/app/routes/api.v1.bulk-actions.$bulkActionId.abort.ts

@@ -1,8 +1,10 @@
 import { json } from "@remix-run/server-runtime";
 import { z } from "zod";
 import { prisma } from "~/db.server";
+import { logger } from "~/services/logger.server";
 import { createActionApiRoute } from "~/services/routeBuilders/apiBuilder.server";
 import { BulkActionService } from "~/v3/services/bulk/BulkActionV2.server";
+import { ServiceValidationError } from "~/v3/services/common.server";
 
 const ParamsSchema = z.object({
   bulkActionId: z.string(),
@@ -34,10 +36,12 @@ const { action } = createActionApiRoute(
       const result = await service.abort(params.bulkActionId, authentication.environment.id);
       return json({ id: result.bulkActionId });
     } catch (error) {
-      return json(
-        { error: error instanceof Error ? error.message : "Failed to abort bulk action" },
-        { status: 400 }
-      );
+      if (error instanceof ServiceValidationError) {
+        return json({ error: error.message }, { status: error.status ?? 400 });
+      }
+
+      logger.error("Failed to abort API bulk action", { error });
+      return json({ error: "Failed to abort bulk action" }, { status: 500 });
     }
   }
 );

apps/webapp/app/routes/api.v1.bulk-actions.ts

@@ -57,10 +57,7 @@ const { action } = createActionApiRoute(
       }
 
       logger.error("Failed to create API bulk action", { error });
-      return json(
-        { error: error instanceof Error ? error.message : "Failed to create bulk action" },
-        { status: 500 }
-      );
+      return json({ error: "Failed to create bulk action" }, { status: 500 });
     }
   }
 );

apps/webapp/app/v3/services/bulk/BulkActionV2.server.ts

@@ -482,15 +482,15 @@ export class BulkActionService extends BaseService {
     });
 
     if (!group) {
-      throw new Error(`Bulk action not found: ${friendlyId}`);
+      throw new ServiceValidationError("Bulk action not found", 404);
     }
 
     if (group.status === BulkActionStatus.COMPLETED) {
-      throw new Error(`Bulk action group already completed: ${friendlyId}`);
+      throw new ServiceValidationError("Bulk action is already completed", 409);
     }
 
     if (group.status === BulkActionStatus.ABORTED) {
-      throw new Error(`Bulk action group already aborted: ${friendlyId}`);
+      throw new ServiceValidationError("Bulk action is already aborted", 409);
     }
 
     //ack the job (this doesn't guarantee it won't run again)