Skip to content

Commit b4d6f67

Browse files
committed
docs(supervisor): scope the reclaim comment to runner-driven completion
1 parent 9370e2c commit b4d6f67

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

  • apps/supervisor/src/workloadServer

apps/supervisor/src/workloadServer/index.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,12 @@ export class WorkloadServer extends EventEmitter<WorkloadServerEvents> {
231231
* reclaimCheckpoints asks the checkpoint service to delete a finished run's checkpoint storage.
232232
*
233233
* Called only after the reply has been sent, so it never delays the runner - the same shape the
234-
* suspend route uses. Every early return is counted: with no lifecycle expiry behind this, a
235-
* silently skipped delete is storage leaked forever, and silence must not look like success.
234+
* suspend route uses. Every early return is counted: nothing reclaims storage behind this, so a
235+
* silently skipped request leaks it, and silence must not look like success.
236+
*
237+
* This covers runner-driven completion only. A run that dies without posting one - killed pod,
238+
* OOM, node loss, platform-side expiry - is finalised on the platform, which the worker never
239+
* hears about, so those are not reclaimed here and are not reclaimable from this side.
236240
*
237241
* `RUN_PENDING_CANCEL` is terminal too - a run cancelled mid-execution never restores - so it is
238242
* reclaimed alongside `RUN_FINISHED`. Retries are deliberately excluded: the prefix is run-level,

0 commit comments

Comments
 (0)