Skip to content

Conversation

@ericallam
Copy link
Member

@ericallam ericallam commented Dec 5, 2025

Note

Updates BatchTriggerV3Service to send batch.id (not friendlyId) as batchId to TriggerTaskService.call.

Written by Cursor Bugbot for commit 68bf8df. This will update automatically on new commits. Configure here.

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2025

⚠️ No Changeset found

Latest commit: 68bf8df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request changes the batch identifier passed to TriggerTaskService.call inside BatchTriggerV3Service.processBatchTaskRunItem, replacing batch.friendlyId with batch.id for the batchId option. No other logic, error handling, or control flow changes are included.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify semantic difference between batch.id and batch.friendlyId and confirm the substitution is correct.
  • Inspect TriggerTaskService.call and downstream consumers of the batchId option to ensure they accept the new identifier type/format.
  • Search for other call sites that pass batch.friendlyId as batchId to determine if similar updates are needed for consistency.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is empty. The required template includes critical sections like Testing, Changelog, and issue reference, none of which are provided. Fill in all required template sections: close an issue, describe testing steps, provide a changelog entry, and confirm adherence to contributing guidelines.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the fix: batch triggering via v3 SDK on v4 projects now works without errors, directly matching the code change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 876037a and 68bf8df.

📒 Files selected for processing (1)
  • apps/webapp/app/v3/services/batchTriggerV3.server.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ericallam ericallam force-pushed the fixes-batch-trigger-v3 branch from 876037a to 68bf8df Compare December 9, 2025 09:53
@ericallam ericallam merged commit 28c0c78 into main Dec 9, 2025
28 of 29 checks passed
@ericallam ericallam deleted the fixes-batch-trigger-v3 branch December 9, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants