Skip to content

Commit 29fbfce

Browse files
louis-zlouis-z
authored
Adapt NGitLab.sln to use Central Package Management (#1060)
* Adapt NGitLab.sln to use Central Package Management Use [CentralisedPackageConverter](https://github.com/Webreaper/CentralisedPackageConverter?tab=readme-ov-file#centralisedpackageconverter) to automatically convert NGitLab.sln's projects * tweak
1 parent 69eb252 commit 29fbfce

6 files changed

Lines changed: 67 additions & 39 deletions

File tree

‎Directory.Build.props‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project>
1+
<Project>
22
<PropertyGroup>
33
<!-- Assembly Info -->
44
<Company>Ubisoft</Company>
@@ -28,32 +28,32 @@
2828
<SourceRoot Include="$(MSBuildThisFileDirectory)/" />
2929

3030
<AdditionalFiles Include="$(MSBuildThisFileDirectory)/BannedSymbols.txt" Link="Properties/BannedSymbols.txt" />
31-
<PackageReference Include="MinVer" PrivateAssets="All" Version="7.0.0" />
31+
<PackageReference Include="MinVer" PrivateAssets="All" />
3232

33-
<PackageReference Include="DotNet.ReproducibleBuilds" Version="2.0.2">
33+
<PackageReference Include="DotNet.ReproducibleBuilds">
3434
<PrivateAssets>all</PrivateAssets>
3535
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
3636
</PackageReference>
3737
</ItemGroup>
3838

3939
<!-- Analyzers (Roslyn, Meziantou, StyleCop, ...) -->
4040
<ItemGroup>
41-
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="10.0.103">
41+
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers">
4242
<PrivateAssets>all</PrivateAssets>
4343
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
4444
</PackageReference>
4545

46-
<PackageReference Include="Meziantou.Analyzer" Version="3.0.15">
46+
<PackageReference Include="Meziantou.Analyzer">
4747
<PrivateAssets>all</PrivateAssets>
4848
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
4949
</PackageReference>
5050

51-
<PackageReference Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="3.3.4">
51+
<PackageReference Include="Microsoft.CodeAnalysis.BannedApiAnalyzers">
5252
<PrivateAssets>all</PrivateAssets>
5353
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
5454
</PackageReference>
5555

56-
<PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.556">
56+
<PackageReference Include="StyleCop.Analyzers">
5757
<PrivateAssets>all</PrivateAssets>
5858
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
5959
</PackageReference>

‎Directory.Packages.props‎

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
<Project>
2+
<PropertyGroup>
3+
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
4+
<CentralPackageTransitivePinningEnabled>false</CentralPackageTransitivePinningEnabled>
5+
</PropertyGroup>
6+
<ItemGroup>
7+
<PackageVersion Include="coverlet.collector" Version="8.0.0" />
8+
<PackageVersion Include="Docker.DotNet" Version="3.125.15" />
9+
<PackageVersion Include="DotNet.ReproducibleBuilds" Version="2.0.2" />
10+
<PackageVersion Include="LibGit2Sharp" Version="0.30.0" />
11+
<PackageVersion Include="Meziantou.Analyzer" Version="3.0.15" />
12+
<PackageVersion Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="3.3.4" />
13+
<PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="10.0.103" />
14+
<PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4" />
15+
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
16+
<PackageVersion Include="Microsoft.Playwright" Version="1.58.0" />
17+
<PackageVersion Include="MinVer" Version="7.0.0" />
18+
<PackageVersion Include="NeoSmart.AsyncLock" Version="3.2.1" />
19+
<PackageVersion Include="NSubstitute" Version="5.3.0" />
20+
<PackageVersion Include="NuGet.Versioning" Version="7.3.0" />
21+
<PackageVersion Include="NUnit" Version="4.5.0" />
22+
<PackageVersion Include="NUnit.Analyzers" Version="4.11.2" />
23+
<PackageVersion Include="NUnit3TestAdapter" Version="6.1.0" />
24+
<PackageVersion Include="Polly" Version="8.6.5" />
25+
<PackageVersion Include="StyleCop.Analyzers" Version="1.2.0-beta.556" />
26+
<PackageVersion Include="Verify.NUnit" Version="31.7.3" />
27+
<PackageVersion Include="YamlDotNet" Version="16.3.0" />
28+
</ItemGroup>
29+
<ItemGroup Condition="'$(TargetFramework)' != 'net8.0'">
30+
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
31+
<PackageVersion Include="PolySharp" Version="1.15.0" />
32+
<PackageVersion Include="System.ComponentModel.Annotations" Version="5.0.0" />
33+
<PackageVersion Include="System.Text.Json" Version="8.0.5" />
34+
</ItemGroup>
35+
</Project>

‎NGitLab.Mock.Tests/NGitLab.Mock.Tests.csproj‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
33
<TargetFrameworks>net8.0;net472</TargetFrameworks>
44
<IsPackable>false</IsPackable>
@@ -7,13 +7,13 @@
77
<ProjectReference Include="..\NGitLab.Mock\NGitLab.Mock.csproj" />
88
</ItemGroup>
99
<ItemGroup>
10-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
11-
<PackageReference Include="NUnit" Version="4.5.0" />
12-
<PackageReference Include="NUnit.Analyzers" Version="4.11.2">
10+
<PackageReference Include="Microsoft.NET.Test.Sdk" />
11+
<PackageReference Include="NUnit" />
12+
<PackageReference Include="NUnit.Analyzers">
1313
<PrivateAssets>all</PrivateAssets>
1414
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1515
</PackageReference>
16-
<PackageReference Include="NUnit3TestAdapter" Version="6.1.0" />
17-
<PackageReference Include="Verify.NUnit" Version="31.7.3" />
16+
<PackageReference Include="NUnit3TestAdapter" />
17+
<PackageReference Include="Verify.NUnit" />
1818
</ItemGroup>
1919
</Project>

‎NGitLab.Mock/NGitLab.Mock.csproj‎

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,12 @@
77
<ProjectReference Include="..\NGitLab\NGitLab.csproj" />
88
</ItemGroup>
99
<ItemGroup>
10-
<PackageReference Include="LibGit2Sharp" Version="0.30.0" />
11-
<PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4">
10+
<PackageReference Include="LibGit2Sharp" />
11+
<PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers">
1212
<PrivateAssets>all</PrivateAssets>
1313
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1414
</PackageReference>
15-
<PackageReference Include="NeoSmart.AsyncLock" Version="3.2.1" />
16-
<PackageReference Include="YamlDotNet" Version="16.3.0" />
17-
</ItemGroup>
18-
19-
<ItemGroup Condition="$(TargetFramework) == 'net472'">
20-
<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3">
21-
<PrivateAssets>all</PrivateAssets>
22-
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
23-
</PackageReference>
15+
<PackageReference Include="NeoSmart.AsyncLock" />
16+
<PackageReference Include="YamlDotNet" />
2417
</ItemGroup>
2518
</Project>

‎NGitLab.Tests/NGitLab.Tests.csproj‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,19 @@
77
<ProjectReference Include="..\NGitLab\NGitLab.csproj" />
88
</ItemGroup>
99
<ItemGroup>
10-
<PackageReference Include="Docker.DotNet" Version="3.125.15" />
11-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
12-
<PackageReference Include="Microsoft.Playwright" Version="1.58.0" />
13-
<PackageReference Include="NuGet.Versioning" Version="7.3.0" />
14-
<PackageReference Include="NUnit" Version="4.5.0" />
15-
<PackageReference Include="NUnit.Analyzers" Version="4.11.2">
10+
<PackageReference Include="Docker.DotNet" />
11+
<PackageReference Include="Microsoft.NET.Test.Sdk" />
12+
<PackageReference Include="Microsoft.Playwright" />
13+
<PackageReference Include="NuGet.Versioning" />
14+
<PackageReference Include="NUnit" />
15+
<PackageReference Include="NUnit.Analyzers">
1616
<PrivateAssets>all</PrivateAssets>
1717
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1818
</PackageReference>
19-
<PackageReference Include="NUnit3TestAdapter" Version="6.1.0" />
20-
<PackageReference Include="NSubstitute" Version="5.3.0" />
21-
<PackageReference Include="Polly" Version="8.6.5" />
22-
<PackageReference Include="coverlet.collector" Version="8.0.0">
19+
<PackageReference Include="NUnit3TestAdapter" />
20+
<PackageReference Include="NSubstitute" />
21+
<PackageReference Include="Polly" />
22+
<PackageReference Include="coverlet.collector">
2323
<PrivateAssets>all</PrivateAssets>
2424
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
2525
</PackageReference>

‎NGitLab/NGitLab.csproj‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,20 @@
66
</PropertyGroup>
77

88
<ItemGroup>
9-
<PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4">
9+
<PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers">
1010
<PrivateAssets>all</PrivateAssets>
1111
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1212
</PackageReference>
1313
</ItemGroup>
1414

1515
<ItemGroup Condition="'$(TargetFramework)' != 'net8.0'">
16-
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
17-
<PackageReference Include="PolySharp" Version="1.15.0">
16+
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" />
17+
<PackageReference Include="PolySharp">
1818
<PrivateAssets>all</PrivateAssets>
1919
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2020
</PackageReference>
21-
<PackageReference Include="System.ComponentModel.Annotations" Version="5.0.0" />
22-
<PackageReference Include="System.Text.Json" Version="8.0.5" />
21+
<PackageReference Include="System.ComponentModel.Annotations" />
22+
<PackageReference Include="System.Text.Json" />
2323
<Reference Include="System.Net.Http" Condition="'$(TargetFramework)' == 'net472'" />
2424
</ItemGroup>
2525

0 commit comments

Comments
 (0)