Skip to content

Commit a5efcd8

Browse files
authored
chore: use bun.Ident in OrderBy (#1286)
1 parent 00498d0 commit a5efcd8

File tree

9 files changed

+12
-9
lines changed

9 files changed

+12
-9
lines changed

internal/dbtest/query_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1873,7 +1873,10 @@ func TestQuery(t *testing.T) {
18731873
{
18741874
id: 194,
18751875
query: func(db *bun.DB) schema.QueryAppender {
1876-
return db.NewSelect().OrderBy("foo", bun.OrderAsc)
1876+
return db.NewSelect().
1877+
OrderBy("foo", bun.OrderAsc).
1878+
OrderBy("foo.bar", bun.OrderDesc).
1879+
OrderBy("xxx", bun.Order("bad"))
18771880
},
18781881
},
18791882
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
SELECT * ORDER BY `foo` ASC
1+
SELECT * ORDER BY `foo` ASC, `foo`.`bar` DESC, `xxx`
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
SELECT * ORDER BY "foo" ASC
1+
SELECT * ORDER BY "foo" ASC, "foo"."bar" DESC, "xxx"
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
SELECT * ORDER BY `foo` ASC
1+
SELECT * ORDER BY `foo` ASC, `foo`.`bar` DESC, `xxx`
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
SELECT * ORDER BY `foo` ASC
1+
SELECT * ORDER BY `foo` ASC, `foo`.`bar` DESC, `xxx`
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
SELECT * ORDER BY "foo" ASC
1+
SELECT * ORDER BY "foo" ASC, "foo"."bar" DESC, "xxx"
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
SELECT * ORDER BY "foo" ASC
1+
SELECT * ORDER BY "foo" ASC, "foo"."bar" DESC, "xxx"
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
SELECT * ORDER BY "foo" ASC
1+
SELECT * ORDER BY "foo" ASC, "foo"."bar" DESC, "xxx"

query_base.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1493,7 +1493,7 @@ func (q *orderLimitOffsetQuery) addOrder(orders ...string) {
14931493
}
14941494

14951495
func (q *orderLimitOffsetQuery) addOrderBy(colName string, sortDir Order) {
1496-
q.addOrderExpr("? ?", Name(colName), sortDir)
1496+
q.addOrderExpr("? ?", Ident(colName), sortDir)
14971497
}
14981498

14991499
func (q *orderLimitOffsetQuery) addOrderExpr(query string, args ...any) {

0 commit comments

Comments
 (0)