Skip to content

Conversation

@libutcher
Copy link
Contributor

This MR includes minor style edits to the desktop app authentication code comments and error messages, including:

  • Clarifies in example code comment that you need to set the account name to match the name at the top left sidebar of the app.
  • Clarifies in error message the exact setting you need to make sure is enabled and how to find it.

@github-actions
Copy link

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@libutcher libutcher requested a review from moward98 November 25, 2025 15:33
@libutcher libutcher self-assigned this Nov 25, 2025
@libutcher libutcher added the documentation Improvements or additions to documentation label Nov 25, 2025
Copy link
Contributor

@moward98 moward98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@libutcher
Copy link
Contributor Author

Thanks @moward98! I'll get this merged once I've fixed the signing issue (waiting for a new PAT to be approved). Then I'll tag you in to review the same changes in JS & Go.

@libutcher libutcher force-pushed the lucy/intf-1039-style branch from e6d7ec9 to 70c874a Compare December 3, 2025 15:02
@libutcher libutcher merged commit 1c18eeb into beta Dec 3, 2025
18 checks passed
@libutcher libutcher deleted the lucy/intf-1039-style branch December 3, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants