Skip to content

fix(S1075): replace hardcoded ToolInformationUri with ThisAssembly.Info.RepositoryUrl #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
304NotModified merged 2 commits into from
Apr 17, 2026
Merged

fix(S1075): replace hardcoded ToolInformationUri with ThisAssembly.Info.RepositoryUrl #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea36b5f
Initial plan
Copilot Apr 17, 2026
c496dd1
fix: resolve SonarCloud S1075 by replacing hardcoded URI with ThisAss…
Copilot Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/SLNX-validator.Core/SLNX-validator.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.*" />
<PackageReference Include="Microsoft.Extensions.FileSystemGlobbing" Version="*" />
<PackageReference Include="ThisAssembly.AssemblyInfo" Version="2.*" PrivateAssets="all" />
</ItemGroup>

<ItemGroup>
<Constant Include="Info.RepositoryUrl" Value="$(RepositoryUrl)" Root="." RootComment="Provides access to assembly attributes defined in the project as constants." />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion src/SLNX-validator.Core/SarifReporting/SarifReporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
private const string SarifSchema = "https://json.schemastore.org/sarif-2.1.0.json";
private const string SarifVersion = "2.1.0";
private const string ToolName = "slnx-validator";
private const string ToolInformationUri = "https://github.com/304NotModified/SLNX-validator";
private static readonly string ToolInformationUri = ThisAssembly.Info.RepositoryUrl;

public override async Task WriteReportAsync(ReportResults reportResults, Stream outputStream)

Check warning on line 15 in src/SLNX-validator.Core/SarifReporting/SarifReporter.cs

View workflow job for this annotation

GitHub Actions / sonarcloud 

Rename parameter 'reportResults' to 'results' to match the base class declaration.

Check warning on line 15 in src/SLNX-validator.Core/SarifReporting/SarifReporter.cs

View workflow job for this annotation

GitHub Actions / sonarcloud 

Rename parameter 'reportResults' to 'results' to match the base class declaration.
{
var usedCodes = reportResults.UsedCodes;

Expand Down
Loading