Skip to content

Conversation

@JoshKowi
Copy link
Collaborator

No description provided.

@JoshKowi
Copy link
Collaborator Author

On my local computer the tests also work, i am not sure why the code on github doesnt get the pdf file.

@JoshKowi JoshKowi requested a review from holybiber November 29, 2024 14:29
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.93617% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.47%. Comparing base (6429b68) to head (7871626).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pywikitools/test/test_export_pdf.py 98.92% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   84.64%   85.47%   +0.82%     
==========================================
  Files          63       65       +2     
  Lines        5140     5348     +208     
==========================================
+ Hits         4351     4571     +220     
+ Misses        789      777      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holybiber holybiber merged commit 59d1c46 into 4training:main Dec 2, 2024
2 checks passed
Copy link
Contributor

@holybiber holybiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, most of it looked very good! There were a few unnecessary lines und a few things taken from ExportHTML that don't belong here - see my last commit.
I looked at the coverage report and there are a few lines still not covered but that's fine for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants