-
Notifications
You must be signed in to change notification settings - Fork 447
Feat: Update RL on Multi-Host TPUs tutorial for clarity and structure #2890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+109
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
a6e8759 to
e3f3b71
Compare
A9isha
reviewed
Jan 3, 2026
A9isha
approved these changes
Jan 5, 2026
Collaborator
A9isha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval pending resolution of all comments
Thank you Jacky!
2c621cf to
a45f9fe
Compare
SurbhiJainUSC
approved these changes
Jan 6, 2026
48eb288 to
09d29f6
Compare
Fix: Update installation instructions and Docker image references in RL on Multi-Host TPUs tutorial fix: Update RL tutorial for clarity and workload management fix: Improve clarity and details in RL tutorial fix: Remove zone specification for XPK v0.14.0+ fix: Update workload variable naming in RL tutorial
09d29f6 to
7a2b4b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update reorganizes the multi-host TPU reinforcement learning tutorial for MaxText, Tunix, and vLLM, adding a table of contents and revising the sections for environment setup, checkpoint conversion, and Docker image creation. It separates the steps for stable versus local builds, updates the workload submission commands for GRPO and GSPO, and adds a section for troubleshooting.
Tests
Verified the updated documentation by walking through the entire workflow, including environment setup, Docker image builds, and workload submission. The commands executed successfully as described. Attached are two test logs confirming the results.
GRPO log
GSPO log
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.