Tasks Improvement: Enhanced Benchmarking and Task Organization#24
Merged
irvineoy merged 7 commits intoAMD-AGI:mainfrom Mar 12, 2026
Merged
Tasks Improvement: Enhanced Benchmarking and Task Organization#24irvineoy merged 7 commits intoAMD-AGI:mainfrom
irvineoy merged 7 commits intoAMD-AGI:mainfrom
Conversation
… reporting. Remove PERF_SHAPE_IDX and add configurable WARMUP_ITERATIONS/BENCHMARK_ITERATIONS constants.
…d ROCm compile issues
Contributor
|
LGTM, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks Improvement: Enhanced Benchmarking and Task Organization
Summary
This PR introduces improvements to the task infrastructure, including the addition of 24 new hip2hip tasks, reorganization of existing tasks, and refactoring of benchmarking logic to run performance tests on all test cases with improved configurability.
Key Changes
1. New Tasks Added (24 hip2hip/gpumode tasks)
Added comprehensive task implementations for:
2. Task Organization Improvements
others/subfolder: Reorganized existing hip2hip tasks (assign_score_withk, ball_query, furthest_point_sample, gather_points, knn, matrix_multiplication, points_in_boxes, roiaware_pool3d, roipoint_pool3d, silu, three_interpolate, three_nn) into a dedicatedothers/subfolder for better structure and maintainability.3. Benchmarking Enhancements
vllm Task Runners Refactoring
PERF_SHAPE_IDX: Eliminated the limitation of benchmarking only a single test caseWARMUP_ITERATIONSandBENCHMARK_ITERATIONSconstants for fine-grained controlhip2hip/others Task Runners Improvements
Testing
task_validator(claude) on all 24 newly added hip2hip/gpumode tasks to verify correctness and proper structurehip2hip/gpumodetaskship2hip/otherstaskstriton2triton/vlltasks