ADD: Some bugfixes to get the unit test to work.#18
Merged
rcjackson merged 1 commit intoARM-Development:mainfrom Mar 5, 2026
Merged
ADD: Some bugfixes to get the unit test to work.#18rcjackson merged 1 commit intoARM-Development:mainfrom
rcjackson merged 1 commit intoARM-Development:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Bugs Found
radclss_core.py:476 — nexrad_columns.drop() when nexrad=False
nexrad_columns is None when nexrad=False, but .drop() is called unconditionally.
nexrad_columns = nexrad_columns.drop(["time_offset", "base_time"]) # crashes if nexrad=False
Fix: wrap in if nexrad_columns is not None:.
radclss_core.py:409,411 — .resample() not followed by aggregation
ds_concat[k].resample(time=time_coords) returns a DatasetResample, not a Dataset. Then .reindex() is called on it, which crashes with AttributeError. This code path is hit by test_radclss_serial_with_5min_time.
radclss_core.py — volumes["sonde"] KeyError when sonde not provided
volumes["sonde"] raises KeyError if sonde files aren't included (e.g. test_radclss_parallel_with_nexrad).
Fix: volumes.get("sonde").
Will no longer crash on no sonde data.
No need for support for time averaging at this point after coordination with the mentors.