Skip to content

Fix missing origin annotations for MDL#2806

Open
jreichel-nvidia wants to merge 4 commits intoAcademySoftwareFoundation:mainfrom
jreichel-nvidia:empty-origin-annotation
Open

Fix missing origin annotations for MDL#2806
jreichel-nvidia wants to merge 4 commits intoAcademySoftwareFoundation:mainfrom
jreichel-nvidia:empty-origin-annotation

Conversation

@jreichel-nvidia
Copy link
Contributor

These are based on the node paths and were missing for the second input of a unit transform node and input sockets of node graphs.

jreichel-nvidia and others added 2 commits March 9, 2026 16:11
These are based on the node paths and were missing for the second input of a
unit transform node and input sockets of node graphs.
@jreichel-nvidia
Copy link
Contributor Author

On second thought I'm not that sure anymore about the change for the unit transform node. Do we want multiple nodes with the same path? I don't know where paths are used elsewhere and would leave that decision to others.

If the decision is that multiple nodes with the same path is ok/the correct thing to do, then we might want to avoid for the MDL backend multiple parameters with the same origin annotations. These are used by integrations to map arguments for the MaterialX material to parameters of the generated MDL code. The 2nd input of the unit transform node does not have a direct counterpart in the original material. Mapping the value from that path would be logically wrong (and doesn't work anyway because of type mismatches). Instead of asking all integrations to add code for this special case it is probably better not to emit the origin annotation in this case (as before my change).

@jstone-lucasfilm jstone-lucasfilm changed the title Fix missing origin annotations for MDL. Fix missing origin annotations for MDL Mar 22, 2026
@jstone-lucasfilm
Copy link
Member

@jreichel-nvidia This single-line change looks fine to me, assuming it addresses the issue you're encountering in MDL. Can you provide a quick description of the case that it addresses?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants