Add MDL support for geomcolor nodes with index 0#2835
Merged
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom Mar 22, 2026
Merged
Add MDL support for geomcolor nodes with index 0#2835jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Index 0 is mapped to scene::data_lookup_<ltype>("GEOMCOLOR0"). Zero is returned
for all other indices (as before).
This could be extended later with a generator option to specify the upper bound
for the indices to be supported.
jstone-lucasfilm
changed the title
jstone-lucasfilm
approved these changes
Mar 22, 2026
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
Thanks for the improvement, @jreichel-nvidia!
jstone-lucasfilm
merged commit ee85ced
into
AcademySoftwareFoundation:main
36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Index 0 is mapped to scene::data_lookup_("GEOMCOLOR0"). Zero is returned for all other indices (as before).
This could be extended later with a generator option to specify the upper bound for the indices to be supported.