Skip to content

fix: Watch the IsEnabled property to lazily activate on Unix#715

Merged
DataTriny merged 1 commit into
mainfrom
unix-lazy-init-switch-prop
May 23, 2026
Merged

fix: Watch the IsEnabled property to lazily activate on Unix#715
DataTriny merged 1 commit into
mainfrom
unix-lazy-init-switch-prop

Conversation

@DataTriny
Copy link
Copy Markdown
Member

Closes #713

Following this commit in at-spi2-core we need to stop relying on the now removed ScreenReaderEnabled bus property and switched to monitor IsEnabled instead, which should be more reliable.

@DataTriny
Copy link
Copy Markdown
Member Author

I'm not currently able to validate this on a Freedesktop environment.

@RastislavKish it would be great if you could apply lazy-activation-debug.patch on top of this branch then try the simple winit example. Let me know if the tree gets initialized immediately when Orca was previously running, if it can be first initialized later if Orca is not initially running and if it can be deactivated and reactivated during the app lifecycle.

Thank you for your help.

@RastislavKish
Copy link
Copy Markdown

@DataTriny looks good! I have installed at-spi-2-core from source and things seem to be working well, I can see both activation and deactivation reports as I turn on / off the screenreader. Everything also works as expected regardless when the screenreader is started i.e. before or after launching the app. Great work on both your and Mike's side!

@DataTriny DataTriny requested a review from mwcampbell May 23, 2026 16:46
Copy link
Copy Markdown
Contributor

@mwcampbell mwcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DataTriny Looks good to me, and I see we got a successful test result. Please merge and release when ready.

@DataTriny DataTriny merged commit e7299a7 into main May 23, 2026
21 checks passed
@DataTriny DataTriny deleted the unix-lazy-init-switch-prop branch May 23, 2026 18:00
@DataTriny DataTriny mentioned this pull request May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AccessKit no longer detects when Orca is running

3 participants